Skip to content

feat(aws): add partition tag#3966

Merged
dd-mergequeue[bot] merged 4 commits into
mainfrom
seunglee/CLP-1021
Sep 25, 2025
Merged

feat(aws): add partition tag#3966
dd-mergequeue[bot] merged 4 commits into
mainfrom
seunglee/CLP-1021

Conversation

@seungleelee

@seungleelee seungleelee commented Sep 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds a aws.partition tag onto AWS traces based on the region. The logic to derive this partition is identical to what we do within the SQS arn extraction logic we added earlier.

Motivation

Part of a larger effort to better link cloud resources within Datadog. We often need the AWS partition during downstream enrichment - it is almost always a required part of constructing an ARN, but it's currently not captured in the library

Jira Ticket and more context around this effort

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 15, 2025
@pr-commenter

pr-commenter Bot commented Sep 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-24 15:08:21

Comparing candidate commit fe92c5f in PR branch seunglee/CLP-1021 with baseline commit e2c8d45 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@seungleelee
seungleelee marked this pull request as ready for review September 15, 2025 18:24
@seungleelee
seungleelee requested review from a team as code owners September 15, 2025 18:24
darccio
darccio approved these changes Sep 25, 2025
View reviewed changes

@darccio darccio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seungleelee

seungleelee commented Sep 25, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 25, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-25 19:58:28 UTC ℹ️ Start processing command /merge

2025-09-25 19:58:33 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 17m (p90).

2025-09-25 20:11:26 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit c8541f5 into main Sep 25, 2025
390 of 395 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the seunglee/CLP-1021 branch September 25, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@seungleelee @darccio