Skip to content

feat(instrumentation/errortrace): Add orchestrion integration#3964

Merged
kakkoyun merged 8 commits into
DataDog:mainfrom
kakkoyun:kakkoyun/LANGPLAT-93/add_errortrace_orchestrion_integration
Oct 15, 2025
Merged

feat(instrumentation/errortrace): Add orchestrion integration#3964
kakkoyun merged 8 commits into
DataDog:mainfrom
kakkoyun:kakkoyun/LANGPLAT-93/add_errortrace_orchestrion_integration

Conversation

@kakkoyun

@kakkoyun kakkoyun commented Sep 11, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Adds a new orchestrion integration for error tracing.

Motivation

In order to enable using orchestrion to automatically trace error stack traces, we need to register the errortrace package as an integration. This builds upon #3709

Jira: LANGPLAT-160

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Fixes #3168

Supersedes #3836

Signed-off-by: Kemal Akkoyun [email protected]

@kakkoyun
kakkoyun force-pushed the kakkoyun/LANGPLAT-93/add_errortrace_orchestrion_integration branch 13 times, most recently from 5c32182 to 8446586 Compare October 2, 2025 16:28
@darccio

darccio commented Oct 7, 2025

Copy link
Copy Markdown
Member

@kakkoyun Could you rebase your PR? I'm trying to investigate the issues but the flaky tests fixed in main are getting on my way. Thanks!

@kakkoyun
kakkoyun force-pushed the kakkoyun/LANGPLAT-93/add_errortrace_orchestrion_integration branch from 8446586 to 3dba94e Compare October 7, 2025 13:21
darccio
darccio requested changes Oct 7, 2025
View reviewed changes
Comment thread instrumentation/errortrace/orchestrion.yml
@kakkoyun
kakkoyun force-pushed the kakkoyun/LANGPLAT-93/add_errortrace_orchestrion_integration branch 4 times, most recently from a59fc78 to 19f1476 Compare October 13, 2025 15:09
@kakkoyun
kakkoyun requested a review from darccio October 13, 2025 15:36
@kakkoyun
kakkoyun marked this pull request as ready for review October 13, 2025 15:36
@kakkoyun
kakkoyun requested review from a team as code owners October 13, 2025 15:36
@kakkoyun
kakkoyun requested a review from hannahkm October 13, 2025 15:37
@kakkoyun
kakkoyun force-pushed the kakkoyun/LANGPLAT-93/add_errortrace_orchestrion_integration branch from fddb064 to 2317373 Compare October 14, 2025 09:35
@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-15 08:39:19 UTC ℹ️ Start processing command /merge

2025-10-15 08:39:28 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-15 08:44:23 UTC ⚠️ MergeQueue: This merge request was unqueued

[email protected] unqueued this merge request

@kakkoyun

kakkoyun commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-15 08:42:25 UTC ℹ️ Start processing command /merge

2025-10-15 08:42:28 UTC ❌ MergeQueue

PR already in the queue with status waiting

@kakkoyun

kakkoyun commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

/merge --cancel

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-15 08:44:16 UTC ℹ️ Start processing command /merge --cancel

@kakkoyun

kakkoyun commented Oct 15, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 15, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-15 08:44:42 UTC ℹ️ Start processing command /merge

2025-10-15 08:44:50 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-15 12:22:59 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@kakkoyun
kakkoyun requested a review from darccio October 15, 2025 08:48
@kakkoyun
kakkoyun force-pushed the kakkoyun/LANGPLAT-93/add_errortrace_orchestrion_integration branch from b8b7007 to 938ea84 Compare October 15, 2025 10:17
@kakkoyun
kakkoyun enabled auto-merge (squash) October 15, 2025 11:11
@kakkoyun
kakkoyun disabled auto-merge October 15, 2025 11:11
@kakkoyun
kakkoyun force-pushed the kakkoyun/LANGPLAT-93/add_errortrace_orchestrion_integration branch from 938ea84 to 18dfbec Compare October 15, 2025 11:13
@kakkoyun
chore(docs): Update README.md
adb1696 
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
kakkoyun merged commit 659fd85 into DataDog:main Oct 15, 2025
153 checks passed
@kakkoyun
kakkoyun deleted the kakkoyun/LANGPLAT-93/add_errortrace_orchestrion_integration branch October 15, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tonyredondo tonyredondo tonyredondo approved these changes
@darccio darccio Awaiting requested review from darccio
+1 more reviewer
@GabrielAnca GabrielAnca GabrielAnca approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Orchestrion]: Enable Error Capture for Functions Returning Types Implementing error

4 participants

@kakkoyun @darccio @tonyredondo @GabrielAnca