Skip to content

ci: update import url for one-pipeline scripts#3963

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
ben.db/fix-config-inversion-ci
Sep 10, 2025
Merged

ci: update import url for one-pipeline scripts#3963
dd-mergequeue[bot] merged 1 commit into
mainfrom
ben.db/fix-config-inversion-ci

Conversation

@genesor

@genesor genesor commented Sep 10, 2025

Copy link
Copy Markdown
Member

What does this PR do?

We found a bug in the libdatadog CI scripts related to config centralization. The CI job ran upon tagging a release with the current import URL has an hardcoded language value to nodejs.

I fixed it on the script and we need to import the new ones to have it correctly tagged.

⚠️ This will need to be cherry-picked into the ongoing release to avoid tagging golang keys are nodejs (with our tags, this would create a mess)

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@genesor
genesor requested a review from a team as a code owner September 10, 2025 17:32
@pr-commenter

pr-commenter Bot commented Sep 10, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-10 17:44:01

Comparing candidate commit 5d0090a in PR branch ben.db/fix-config-inversion-ci with baseline commit e7e5c7f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@hannahkm

Copy link
Copy Markdown
Contributor

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 10, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-10 20:15:59 UTC ℹ️ Start processing command /merge


2025-09-10 20:16:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 15m (p90).


2025-09-10 20:29:13 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit c9e657e into main Sep 10, 2025
610 of 638 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the ben.db/fix-config-inversion-ci branch September 10, 2025 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants