Skip to content

feat: add process tags to exposed metadata#3960

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
raphael/process_tags_in_memfd
Sep 30, 2025
Merged

feat: add process tags to exposed metadata#3960
dd-mergequeue[bot] merged 3 commits into
mainfrom
raphael/process_tags_in_memfd

Conversation

@raphaelgavache

@raphaelgavache raphaelgavache commented Sep 10, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Add the collection of process tags in dd-trace-go metadata memfd
Tested against this system-test -> DataDog/system-tests#5292

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@raphaelgavache raphaelgavache changed the title add process tags to memfd feat: add process tags to exposed metadata Sep 10, 2025
@pr-commenter

pr-commenter Bot commented Sep 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-30 04:01:04

Comparing candidate commit 4992162 in PR branch raphael/process_tags_in_memfd with baseline commit e7e5c7f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@raphaelgavache
raphaelgavache marked this pull request as ready for review September 10, 2025 16:48
@raphaelgavache
raphaelgavache requested a review from a team as a code owner September 10, 2025 16:48
@raphaelgavache
raphaelgavache requested a review from a team as a code owner September 29, 2025 23:57
@raphaelgavache
raphaelgavache force-pushed the raphael/process_tags_in_memfd branch from a46181d to 4992162 Compare September 30, 2025 03:44
@raphaelgavache raphaelgavache mentioned this pull request Sep 30, 2025
Merged
6 tasks
genesor
genesor approved these changes Sep 30, 2025
View reviewed changes

@genesor genesor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a quick question, is it normal that it does not impact any unit test ?

@raphaelgavache

raphaelgavache commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

Good question, yes there's a reason there's no unit test. In this particular case the logic can only be tested on a linux machine by parsing /proc/{pid}/fds, which is only covered well on system-tests. Hence the system-test test and no unit one

@raphaelgavache

raphaelgavache commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-30 13:27:06 UTC ℹ️ Start processing command /merge

2025-09-30 13:27:12 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-09-30 13:39:09 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 42fb0ed into main Sep 30, 2025
452 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the raphael/process_tags_in_memfd branch September 30, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genesor genesor genesor approved these changes
@rarguelloF rarguelloF rarguelloF approved these changes

Assignees

No one assigned

Labels

core mergequeue-status: done team:apm-go

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raphaelgavache @genesor @rarguelloF