Skip to content

chore: remove garyburd/redigo dependency#3953

Merged
dd-mergequeue[bot] merged 5 commits into
mainfrom
dario.castane/deprecate-garyburd-redigo-v2
Sep 30, 2025
Merged

chore: remove garyburd/redigo dependency#3953
dd-mergequeue[bot] merged 5 commits into
mainfrom
dario.castane/deprecate-garyburd-redigo-v2

Conversation

@darccio

@darccio darccio commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Updates these dependencies to avoid any indirect dependency with garyburd/redigo:

These are the minimum versions of each library that avoid the repository, as its maintainer wants to delete it (as they did once, causing incidents in multiple customers, as in #3564).

It also depends on PR #3949 (already merged) in release-v1.74.x.

go.work.sum changes are triggered by make fix-modules.

Motivation

Cleaning up our dependency graph, making it more resilient.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 8, 2025
darccio
darccio commented Sep 8, 2025
View reviewed changes
Comment thread tools/v2fix/go.mod Outdated
@darccio
darccio force-pushed the dario.castane/deprecate-garyburd-redigo-v2 branch from 9141df6 to 6767630 Compare September 15, 2025 08:46
@pr-commenter

pr-commenter Bot commented Sep 15, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-29 14:43:11

Comparing candidate commit 82ac06e in PR branch dario.castane/deprecate-garyburd-redigo-v2 with baseline commit c5f0aee in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio
darccio force-pushed the dario.castane/deprecate-garyburd-redigo-v2 branch from 6767630 to 484c3cd Compare September 26, 2025 08:43
@darccio
darccio marked this pull request as ready for review September 26, 2025 08:47
@darccio
darccio requested a review from a team as a code owner September 26, 2025 10:10
@datadog-official

datadog-official Bot commented Sep 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 82ac06e | Docs | Was this helpful? Give us feedback!

@darccio

darccio commented Sep 29, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 29, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-29 08:43:29 UTC ℹ️ Start processing command /merge

2025-09-29 08:43:39 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-29 12:44:10 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@darccio
darccio force-pushed the dario.castane/deprecate-garyburd-redigo-v2 branch from 257778c to 82ac06e Compare September 29, 2025 14:29
@darccio

darccio commented Sep 29, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 29, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-29 14:41:11 UTC ℹ️ Start processing command /merge

2025-09-29 14:41:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-29 18:42:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@dd-mergequeue
dd-mergequeue Bot merged commit 0fe2478 into main Sep 30, 2025
259 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the dario.castane/deprecate-garyburd-redigo-v2 branch September 30, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rarguelloF rarguelloF rarguelloF approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darccio @rarguelloF