Skip to content

chore(contrib/garyburd/redigo): deprecate contrib#3949

Merged
darccio merged 3 commits into
release-v1.74.xfrom
dario.castane/deprecate-garyburd-redigo
Sep 8, 2025
Merged

chore(contrib/garyburd/redigo): deprecate contrib#3949
darccio merged 3 commits into
release-v1.74.xfrom
dario.castane/deprecate-garyburd-redigo

Conversation

@darccio

@darccio darccio commented Sep 8, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Deprecates garyburd/redigo integration.

Motivation

Our telemetry reports that no customer uses this integration and library anymore. It's safe to drop from the v1 release, so it can also be removed from v2 (v1 is imported for the v2fix script tests, thus messing a bit with the repository's go.work).

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested review from a team as code owners September 8, 2025 13:13
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 8, 2025
@darccio darccio changed the title chore(contrib/garyburd/redigo): deprecate garybud/redigo chore(contrib/garyburd/redigo): deprecate contrib Sep 8, 2025
@datadog-official

datadog-official Bot commented Sep 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Tests

⚠️ Warnings

🧪 3 Tests failed

TestGeneratedSpan from gopkg.in/DataDog/dd-trace-go.v1/contrib/envoyproxy/go-control-plane (Datadog) 
Failed

=== RUN   TestGeneratedSpan
--- FAIL: TestGeneratedSpan (0.03s)
TestGeneratedSpan/request-span from gopkg.in/DataDog/dd-trace-go.v1/contrib/envoyproxy/go-control-plane (Datadog) 
Failed

=== RUN   TestGeneratedSpan/request-span
    envoy_test.go:48: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/envoyproxy/go-control-plane/envoy_test.go:236
        	            				/home/runner/work/dd-trace-go/dd-trace-go/contrib/envoyproxy/go-control-plane/envoy_test.go:48
        	Error:      	Received unexpected error:
        	            	EOF
        	Test:       	TestGeneratedSpan/request-span
2025/09/08 15:15:32 Datadog Tracer v2.2.3 ERROR: external_processing: the body parsing has been wrongly configured. Please disable in your Envoy External Processor filter configuration the body processing mode and enable the allow_mode_override option to let the processor handle the processing mode. (occurred: 08 Sep 25 15:15 UTC)
...
TestGeneratedSpan/span-with-injected-context from gopkg.in/DataDog/dd-trace-go.v1/contrib/envoyproxy/go-control-plane (Datadog) 
Failed

=== RUN   TestGeneratedSpan/span-with-injected-context
    envoy_test.go:83: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/envoyproxy/go-control-plane/envoy_test.go:236
        	            				/home/runner/work/dd-trace-go/dd-trace-go/contrib/envoyproxy/go-control-plane/envoy_test.go:83
        	Error:      	Received unexpected error:
        	            	EOF
        	Test:       	TestGeneratedSpan/span-with-injected-context
2025/09/08 15:15:32 Datadog Tracer v2.2.3 ERROR: external_processing: the body parsing has been wrongly configured. Please disable in your Envoy External Processor filter configuration the body processing mode and enable the allow_mode_override option to let the processor handle the processing mode. (occurred: 08 Sep 25 15:15 UTC)
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7af936a | Docs | Was this helpful? Give us feedback!

@darccio

darccio commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

Failing tests are unrelated.

@darccio
darccio merged commit 8304df9 into release-v1.74.x Sep 8, 2025
175 of 194 checks passed
@darccio
darccio deleted the dario.castane/deprecate-garyburd-redigo branch September 8, 2025 15:36
@darccio darccio mentioned this pull request Sep 8, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genesor genesor genesor approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@darccio @genesor