Skip to content

refactor(envoyproxy): prepare to move envoyproxy common code in instrumentation for the future HAProxy contrib#3945

Merged
dd-mergequeue[bot] merged 8 commits into
mainfrom
eliottness/rework-message-proc
Sep 5, 2025
Merged

refactor(envoyproxy): prepare to move envoyproxy common code in instrumentation for the future HAProxy contrib#3945
dd-mergequeue[bot] merged 8 commits into
mainfrom
eliottness/rework-message-proc

Conversation

@eliottness

@eliottness eliottness commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 5, 2025
@eliottness eliottness changed the title refactor(envoyproxy): prepate to move envoyproxy common code in instrumentation for the futureHAProxy contrib refactor(envoyproxy): prepate to move envoyproxy common code in instrumentation for the future HAProxy contrib Sep 5, 2025
@pr-commenter

pr-commenter Bot commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-05 14:36:23

Comparing candidate commit 8292727 in PR branch eliottness/rework-message-proc with baseline commit b5536ad in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness
fix misc with @e-n-0
da85b9d 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
eliottness marked this pull request as ready for review September 5, 2025 13:41
@eliottness
eliottness requested a review from a team as a code owner September 5, 2025 13:41
@eliottness

eliottness commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-05 13:41:31 UTC ℹ️ Start processing command /merge

2025-09-05 13:41:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-05 17:42:10 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@e-n-0 e-n-0 changed the title refactor(envoyproxy): prepate to move envoyproxy common code in instrumentation for the future HAProxy contrib refactor(envoyproxy): prepare to move envoyproxy common code in instrumentation for the future HAProxy contrib Sep 5, 2025
@eliottness
add first request log
7f8f017 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
add first request log
8292727 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness

eliottness commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-05 20:40:02 UTC ℹ️ Start processing command /merge

2025-09-05 20:40:14 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-05 21:07:12 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 15m (p90).

2025-09-05 21:20:00 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 222fce9 into main Sep 5, 2025
264 of 272 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/rework-message-proc branch September 5, 2025 21:19
kakkoyun pushed a commit to kakkoyun/dd-trace-go that referenced this pull request Sep 9, 2025
@eliottness @e-n-0 @kakkoyun
refactor(envoyproxy): prepare to move envoyproxy common code in instr…
43311ba 
…umentation for the future HAProxy contrib (DataDog#3945)

Co-authored-by: e-n-0 <[email protected]>
@e-n-0 e-n-0 mentioned this pull request Sep 12, 2025
Closed
7 tasks
@e-n-0 e-n-0 mentioned this pull request Oct 1, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@e-n-0 e-n-0 e-n-0 approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @e-n-0