Skip to content

feat(contrib/haproxy): add haproxy release and system tests#3944

Merged
dd-mergequeue[bot] merged 4 commits into
mainfrom
flavien/haproxy/releases_systemtests
Oct 8, 2025
Merged

feat(contrib/haproxy): add haproxy release and system tests#3944
dd-mergequeue[bot] merged 4 commits into
mainfrom
flavien/haproxy/releases_systemtests

Conversation

@e-n-0

@e-n-0 e-n-0 commented Sep 5, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR adds the build release for HAProxy and adds the system tests for it.

Motivation

Release + QA

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@e-n-0
e-n-0 changed the base branch from main to flavien/contrib/cmd/spoa September 5, 2025 09:48
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 5, 2025
@pr-commenter

pr-commenter Bot commented Sep 5, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-08 09:40:11

Comparing candidate commit e982f04 in PR branch flavien/haproxy/releases_systemtests with baseline commit f1dd348 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@e-n-0
e-n-0 force-pushed the flavien/haproxy/releases_systemtests branch 3 times, most recently from f09e45e to 371a350 Compare September 5, 2025 12:47
@datadog-official

datadog-official Bot commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: e982f04 | Docs | Was this helpful? Give us feedback!

@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch from 0535995 to b767a5d Compare September 18, 2025 14:35
@e-n-0
e-n-0 force-pushed the flavien/haproxy/releases_systemtests branch 2 times, most recently from 3beb6c0 to 7957f62 Compare September 18, 2025 15:31
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch 2 times, most recently from 3e7de4a to d1b24d6 Compare September 19, 2025 15:18
@e-n-0
e-n-0 force-pushed the flavien/haproxy/releases_systemtests branch from 7957f62 to 83ec5ea Compare September 19, 2025 15:20
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch from d1b24d6 to 0b2ffdc Compare September 19, 2025 15:29
@e-n-0
e-n-0 force-pushed the flavien/haproxy/releases_systemtests branch from 83ec5ea to 94a268b Compare September 19, 2025 15:29
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch 5 times, most recently from c20e62f to 1888def Compare September 29, 2025 09:50
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch 4 times, most recently from 4619683 to 59ae285 Compare October 2, 2025 10:06
Base automatically changed from flavien/contrib/cmd/spoa to main October 2, 2025 23:38
@e-n-0
e-n-0 force-pushed the flavien/haproxy/releases_systemtests branch from 94a268b to 45ee670 Compare October 3, 2025 08:37
@e-n-0
e-n-0 force-pushed the flavien/haproxy/releases_systemtests branch from 45ee670 to 25cc5fb Compare October 3, 2025 08:59
@e-n-0
e-n-0 marked this pull request as ready for review October 6, 2025 12:03
@e-n-0
e-n-0 requested review from a team as code owners October 6, 2025 12:03
Comment thread .github/workflows/docker-images-release.yml Outdated
Comment thread .github/workflows/docker-images-release.yml Outdated
Comment thread .github/workflows/system-tests.yml
Comment thread .github/workflows/system-tests.yml Outdated
@e-n-0
e-n-0 marked this pull request as draft October 6, 2025 12:47
@e-n-0
e-n-0 marked this pull request as ready for review October 8, 2025 09:46
@e-n-0
e-n-0 requested a review from eliottness October 8, 2025 09:55
@e-n-0

e-n-0 commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 09:57:55 UTC ℹ️ Start processing command /merge


2025-10-08 09:58:00 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).


2025-10-08 10:12:50 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit 696e5cf:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@e-n-0

e-n-0 commented Oct 8, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 8, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-08 11:54:05 UTC ℹ️ Start processing command /merge


2025-10-08 11:54:10 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).


2025-10-08 12:05:59 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 5cc699c into main Oct 8, 2025
242 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the flavien/haproxy/releases_systemtests branch October 8, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants