feat: datadog-lambda-go by joeyzhao2018 · Pull Request #3943 · DataDog/dd-trace-go

joeyzhao2018 · 2025-09-03T17:57:20Z

What does this PR do?

We are moving datadog-lambda-go to dd-trace-go (finally) !!!

This PR just

moves the code
adds the go.mod files and changes the relative imports
adapts to the dd-trace-go V2 APIs (the same things we have done in feat: use dd-trace-go v2 datadog-lambda-go#206)

After this PR, datadog-lambda-go's release will be done along with dd-trace-go as github.com/DataDog/dd-trace-go/contrib/aws/datadog-lambda-go/v2

This PR does NOT include

the previous integration tests in datadog-lambda-go. That migration has a dedicated PR: chore: migrate datadog-lambda-go integration tests #3987
System tests and benchmarking updates. We will prioritize those but currently not a block for this migration.

Motivation

Upgrade dd-trace-go v2 datadog-lambda-go#204 datadog-lambda-go needs to use dd-trace-go v2 but releasing a datadog-lambda-goV2 separately will likely cause many maintenance issues and confuse the customers. The best approach is to release it along with dd-trace-go.
Moving datadog-lambda-go to dd-trace-go is in general a better structure for future enhancements and maintenance.
Pave the road for using Orchestrion for AWS Lambda as the internal APIs in this PR will be needed.

Testing

Smoke tested with a real lambda. Note that the datadog-lambda version will be the same as dd-trace-go version.

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.
Add an appropriate team label so this PR gets put in the right place for the release notes.

Benchmark and system-tests are going to be in other PRs.

System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
- If this interacts with the agent in a new way, a system test has been added.
There is a benchmark for any new code, or changes to existing code.

https://datadoghq.atlassian.net/browse/APMSVLS-183

pr-commenter · 2025-09-03T18:00:50Z

Benchmarks

Benchmark execution time: 2025-09-26 14:43:38

Comparing candidate commit 93022f8 in PR branch joey/migration with baseline commit 284745b in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

datadog-official · 2025-09-03T18:06:49Z

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 93022f8 | Docs | Was this helpful? Give us feedback!}

…ation.Version(). cold_start now in string.

joeyzhao2018 · 2025-09-24T19:18:02Z

 	pkgs := GetPackages()
 	for pkg, info := range pkgs {
 		t.Run(string(pkg), func(t *testing.T) {
+			// Skip packages that don't implement analytics functionality


Let me know if this kind of skip is acceptable. Currently the datadog-lambda-go doesn't support instrumentation telemetry

kakkoyun

I haven't checked all the nitty-gritty details of the package itself since it's just a move.

Otherwise, it looks good to me.

We might need to update the CODEOWNERS though.

joeyzhao2018 · 2025-09-26T15:08:49Z

/merge

dd-devflow-routing-codex · 2025-09-26T15:08:53Z

View all feedbacks in Devflow UI.

2025-09-26 15:08:52 UTC ℹ️ Start processing command /merge

2025-09-26 15:08:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-09-26 15:24:58 UTC ℹ️ MergeQueue: This merge request was merged

github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Sep 3, 2025

joeyzhao2018 added 4 commits September 10, 2025 12:52

migrating datadog-lambda-go

9998f97

copyright header fix

6bbaff0

moving go.mod

9eb1e90

update go.mod

7122306

joeyzhao2018 force-pushed the joey/migration branch from c5daabc to 7122306 Compare September 10, 2025 16:56

Merge branch 'main' into joey/migration

6bb1d8f

joeyzhao2018 changed the title ~~Migrate datadog-lambda-go~~ feat: datadog-lambda-go Sep 15, 2025

joeyzhao2018 added 17 commits September 15, 2025 12:56

fix go.mod files

6534248

follow the versioning convention

0947de8

follow the new versioning convention

edee75f

Merge branch 'main' into joey/migration

3615345

update go.work file for datadog-lambda-go

0de2caa

remove lambdatest(integration test) for now

13e4222

use relative path for testdata. fix extension_test.go. use instrument…

8ad7c08

…ation.Version(). cold_start now in string.

Merge branch 'main' into joey/migration

6aa7dd7

go.work.sum update

11b1a5f

skip instrumentation analytics for lambda; versioning compatibility

7c65e0b

update contribs_generated.go

91d334e

update contribs_generated.go in internal/stacktrace

56abae6

Merge branch 'main' into joey/migration

d6dd400

update contribs_generated.go

3e93049

update after fix_modules.sh

681e225

update contribs_generated.go

a3cedf2

update contribs_generated.go

8632e7c

joeyzhao2018 added the serverless label Sep 18, 2025

joeyzhao2018 added 2 commits September 19, 2025 07:55

Merge branch 'main' into joey/migration

b341f42

Merge branch 'main' into joey/migration

22d766c

joeyzhao2018 added 3 commits September 24, 2025 10:35

Merge branch 'main' into joey/migration

a66d5bb

should use TraceIDLower in SendEndInvocationRequest

b270629

update after running fix_modules.sh

a74f8e1

joeyzhao2018 marked this pull request as ready for review September 24, 2025 18:59

joeyzhao2018 requested review from a team as code owners September 24, 2025 18:59

joeyzhao2018 commented Sep 24, 2025

View reviewed changes

joeyzhao2018 added 2 commits September 25, 2025 07:48

Merge branch 'main' into joey/migration

8b4d6a7

use the constants in packages.go

9d07173

purple4reina approved these changes Sep 25, 2025

View reviewed changes

Merge branch 'main' into joey/migration

1506874

joeyzhao2018 mentioned this pull request Sep 25, 2025

chore: migrate datadog-lambda-go integration tests #3987

Merged

kakkoyun reviewed Sep 26, 2025

View reviewed changes

joeyzhao2018 added 2 commits September 26, 2025 10:18

Merge branch 'main' into joey/migration

a8a32a1

update CODEOWNERS

93022f8

joeyzhao2018 requested a review from kakkoyun September 26, 2025 14:51

kakkoyun approved these changes Sep 26, 2025

View reviewed changes

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Sep 26, 2025

dd-mergequeue Bot merged commit 98f6b18 into main Sep 26, 2025
259 checks passed

dd-devflow Bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Sep 26, 2025

dd-mergequeue Bot deleted the joey/migration branch September 26, 2025 15:24

This was referenced Sep 29, 2025

feat: use dd-trace-go v2 DataDog/datadog-lambda-go#206

Closed

[BUG]: dd-trace-go/v2 internal/telemetry when used in AWS Lambda environment posts repeatedly to non-exist agent sidecar #3808

Closed

joeyzhao2018 mentioned this pull request Nov 25, 2025

update the go instrumentation docs after migration DataDog/documentation#33051

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: datadog-lambda-go#3943

feat: datadog-lambda-go#3943
dd-mergequeue[bot] merged 36 commits into
mainfrom
joey/migration

joeyzhao2018 commented Sep 3, 2025 •

edited

Loading

Uh oh!

pr-commenter Bot commented Sep 3, 2025 •

edited

Loading

Uh oh!

datadog-official Bot commented Sep 3, 2025 •

edited by datadog-datadog-prod-us1 Bot

Loading

Uh oh!

joeyzhao2018 Sep 24, 2025

Uh oh!

kakkoyun left a comment

Uh oh!

joeyzhao2018 commented Sep 26, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

joeyzhao2018 commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Testing

Reviewer's Checklist

Uh oh!

pr-commenter Bot commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Uh oh!

datadog-official Bot commented Sep 3, 2025 • edited by datadog-datadog-prod-us1 Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joeyzhao2018 Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

kakkoyun left a comment

Choose a reason for hiding this comment

Uh oh!

joeyzhao2018 commented Sep 26, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

joeyzhao2018 commented Sep 3, 2025 •

edited

Loading

pr-commenter Bot commented Sep 3, 2025 •

edited

Loading

datadog-official Bot commented Sep 3, 2025 •

edited by datadog-datadog-prod-us1 Bot

Loading

dd-devflow-routing-codex Bot commented Sep 26, 2025 •

edited

Loading