Skip to content

fix(ddtrace/tracer): move startup log after appsec has started#3942

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/move-log-startup-after-appsec
Sep 3, 2025
Merged

fix(ddtrace/tracer): move startup log after appsec has started#3942
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/move-log-startup-after-appsec

Conversation

@eliottness

@eliottness eliottness commented Sep 3, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR moves the tracer startup log AFTER appsec has started to be able to log the right value of it being enabled or not

Motivation

To be able to log the right value of appsec being enabled or not.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter

pr-commenter Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-03 12:32:24

Comparing candidate commit 770196f in PR branch eliottness/move-log-startup-after-appsec with baseline commit 169c0c4 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness
eliottness marked this pull request as ready for review September 3, 2025 13:50
@eliottness
eliottness requested a review from a team as a code owner September 3, 2025 13:50
@eliottness

eliottness commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-03 13:51:16 UTC ℹ️ Start processing command /merge

2025-09-03 13:51:40 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-03 13:55:30 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-09-03 14:09:11 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit ee6d621:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@eliottness

eliottness commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-03 14:12:57 UTC ℹ️ Start processing command /merge

2025-09-03 14:13:16 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-09-03 14:25:21 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 1921d92 into main Sep 3, 2025
224 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/move-log-startup-after-appsec branch September 3, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @darccio