Skip to content

fix(.gitlab): change directionality of throughput SLOs#3936

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
augusto/update-slos
Sep 5, 2025
Merged

fix(.gitlab): change directionality of throughput SLOs#3936
dd-mergequeue[bot] merged 2 commits into
mainfrom
augusto/update-slos

Conversation

@igoragoli

@igoragoli igoragoli commented Sep 1, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Changes the directionality of throughput SLO checks.

Motivation

We want the throughputs of instrumented applications to be as high as possible, so I've changed the threshold expression from throughput < 40 op/s to throughput > 30 op/s.

The 30 was determined by looking at latest measurements and computing a low enough threshold that wouldn't trigger warnings:

https://app.datadoghq.com/dashboard/w6a-xc3-kyz/apm-sdk-performance-slos?fromUser=false&refresh_mode=sliding&tpl_var_metric%5B0%5D=throughput&tpl_var_project%5B0%5D=dd-trace-go&from_ts=1754054525311&to_ts=1756732925311&live=true

image

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter

pr-commenter Bot commented Sep 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-04 09:15:30

Comparing candidate commit 59f0ef7 in PR branch augusto/update-slos with baseline commit a3544b2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@igoragoli
igoragoli marked this pull request as ready for review September 3, 2025 08:02
@igoragoli
igoragoli requested a review from a team as a code owner September 3, 2025 08:02
@igoragoli

igoragoli commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-03 09:09:48 UTC ℹ️ Start processing command /merge

2025-09-03 09:09:53 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-09-03 09:10:42 UTC ⚠️ MergeQueue: This merge request build was cancelled

[email protected] cancelled this merge request build

@igoragoli

igoragoli commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

/remove

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 3, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-03 09:10:32 UTC ℹ️ Start processing command /remove

2025-09-03 09:10:38 UTC ℹ️ Devflow: /remove

@igoragoli

igoragoli commented Sep 5, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 5, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-05 08:10:12 UTC ℹ️ Start processing command /merge

2025-09-05 08:10:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-05 10:47:06 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 15m (p90).

2025-09-05 10:59:55 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit e295185 into main Sep 5, 2025
269 of 273 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the augusto/update-slos branch September 5, 2025 10:59
kakkoyun pushed a commit to kakkoyun/dd-trace-go that referenced this pull request Sep 9, 2025
@igoragoli @kakkoyun
fix(.gitlab): change directionality of throughput SLOs (DataDog#3936)
c7707e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@ddyurchenko ddyurchenko Awaiting requested review from ddyurchenko

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@igoragoli @darccio