Skip to content

feat(ci): enable performance SLO change tracking#3935

Merged
dd-mergequeue[bot] merged 4 commits into
mainfrom
augusto/slo-change-detection
Sep 1, 2025
Merged

feat(ci): enable performance SLO change tracking#3935
dd-mergequeue[bot] merged 4 commits into
mainfrom
augusto/slo-change-detection

Conversation

@igoragoli

@igoragoli igoragoli commented Sep 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Update check-slo-breaches to fetch a GitHub token with dd-octo-sts and export it to bp-runner.
  • Add a dd-octo-sts trust policy allowing GitLab CI jobs from all branches/tags to read GitHub contents.
    • This wide scope is necessary to cover manual macrobenchmark runs, which can happen from any branch/tag and cause check-slo-breaches to run.

This is necessary for check-slo-breaches to track SLO changes using GitHub's API.

Motivation

https://datadoghq.atlassian.net/browse/APMSP-2198

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@igoragoli igoragoli changed the title ci: enable performance SLO change tracking chore(ci): enable performance SLO change tracking Sep 1, 2025
@pr-commenter

pr-commenter Bot commented Sep 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-09-01 12:45:21

Comparing candidate commit 2658d99 in PR branch augusto/slo-change-detection with baseline commit 775e331 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@igoragoli igoragoli changed the title chore(ci): enable performance SLO change tracking feat(ci): enable performance SLO change tracking Sep 1, 2025
@igoragoli
igoragoli marked this pull request as ready for review September 1, 2025 12:00
@igoragoli
igoragoli requested a review from a team as a code owner September 1, 2025 12:00
darccio
darccio approved these changes Sep 1, 2025
View reviewed changes

@darccio darccio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CI seems unrelated.

@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Sep 1, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2658d99 | Docs | Was this helpful? Give us feedback!

@igoragoli

igoragoli commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Sep 1, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-09-01 12:47:32 UTC ℹ️ Start processing command /merge

2025-09-01 12:47:45 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-01 13:46:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-09-01 13:56:35 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 32c3ebe into main Sep 1, 2025
231 of 244 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the augusto/slo-change-detection branch September 1, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igoragoli @darccio @kakkoyun