Skip to content

feat(gin/appsec): support for request body analysis and blocking#3930

Merged
dd-mergequeue[bot] merged 5 commits into
mainfrom
eliottness/APPSEC-58773/gin-request-body
Aug 29, 2025
Merged

feat(gin/appsec): support for request body analysis and blocking#3930
dd-mergequeue[bot] merged 5 commits into
mainfrom
eliottness/APPSEC-58773/gin-request-body

Conversation

@eliottness

@eliottness eliottness commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR implements request body analysis and blocking for the gin framework using their binding API

Motivation

Better security support for gin

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 29, 2025
@pr-commenter

pr-commenter Bot commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-29 13:55:50

Comparing candidate commit 3c16acc in PR branch eliottness/APPSEC-58773/gin-request-body with baseline commit 98744a1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness eliottness changed the title feat(gin-gonic/appsec): support for request body analysis and blocking feat(gin/appsec): support for request body analysis and blocking Aug 29, 2025
@eliottness
eliottness marked this pull request as ready for review August 29, 2025 12:32
@eliottness
eliottness requested review from a team as code owners August 29, 2025 12:32
@eliottness
eliottness force-pushed the eliottness/APPSEC-58773/gin-request-body branch from cc25948 to 02ce74a Compare August 29, 2025 12:35
@eliottness
don't log non-appsec users
ef6b6c9 
Signed-off-by: Eliott Bouhana <[email protected]>
RomainMuller
RomainMuller approved these changes Aug 29, 2025
View reviewed changes

@RomainMuller RomainMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor docs nitpicking

Comment thread contrib/gin-gonic/gin/appsec.go Outdated
@eliottness

eliottness commented Aug 29, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-29 13:41:28 UTC ℹ️ Start processing command /merge

2025-08-29 13:41:51 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-29 14:05:21 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-29 14:15:56 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 5c0c071 into main Aug 29, 2025
243 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/APPSEC-58773/gin-request-body branch August 29, 2025 14:15
@sdotson sdotson mentioned this pull request Nov 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @RomainMuller