Skip to content

ci: fix PR title validation regexp#3929

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
ben.db/ci-title-validation-fix
Aug 29, 2025
Merged

ci: fix PR title validation regexp#3929
dd-mergequeue[bot] merged 1 commit into
mainfrom
ben.db/ci-title-validation-fix

Conversation

@genesor

@genesor genesor commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Fixes the regexp used to validate PR titles in conventional commits.

Motivation

This PR is failing. Here is the job passing with the fix (same title used)

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@genesor
genesor force-pushed the ben.db/ci-title-validation-fix branch from b9a8e2d to 6578beb Compare August 29, 2025 11:53
@genesor genesor changed the title fix(contrib/aws/aws-sdk-go-v2): set messaging.system tag in SQS tracing ci: fix PR title validation regexp Aug 29, 2025
@pr-commenter

pr-commenter Bot commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-29 12:11:07

Comparing candidate commit 6578beb in PR branch ben.db/ci-title-validation-fix with baseline commit 98744a1 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@genesor
genesor marked this pull request as ready for review August 29, 2025 11:57
@genesor
genesor requested a review from a team as a code owner August 29, 2025 11:57
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6578beb | Docs | Was this helpful? Give us feedback!

@darccio

darccio commented Aug 29, 2025

Copy link
Copy Markdown
Member

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-29 12:19:31 UTC ℹ️ Start processing command /merge

2025-08-29 12:19:38 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-29 12:31:08 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 482cf52 into main Aug 29, 2025
229 of 235 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the ben.db/ci-title-validation-fix branch August 29, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@genesor @darccio