Skip to content

fix(contrib/aws/aws-sdk-go-v2): set messaging.system tag in SQS tracing#3928

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
therve/sqs
Aug 29, 2025
Merged

fix(contrib/aws/aws-sdk-go-v2): set messaging.system tag in SQS tracing#3928
dd-mergequeue[bot] merged 3 commits into
mainfrom
therve/sqs

Conversation

@therve

@therve therve commented Aug 29, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This is used in the backend to identify spans properly, let's populate it.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@therve
Set messaging.system tag in SQS tracing
36c9462 
This is used in the backend to identify spans properly, let's populate
it.
@therve
therve requested review from a team as code owners August 29, 2025 09:48
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 29, 2025
@pr-commenter

pr-commenter Bot commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-29 12:45:03

Comparing candidate commit 4b6c124 in PR branch therve/sqs with baseline commit 482cf52 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio darccio changed the title Set messaging.system tag in SQS tracing fix(‎contrib/aws/aws-sdk-go-v2): set messaging.system tag in SQS tracing Aug 29, 2025
@genesor genesor changed the title fix(‎contrib/aws/aws-sdk-go-v2): set messaging.system tag in SQS tracing fix(contrib/aws/aws-sdk-go-v2): set messaging.system tag in SQS tracing Aug 29, 2025
@genesor genesor mentioned this pull request Aug 29, 2025
Merged
7 tasks
@therve

therve commented Aug 29, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-29 14:24:19 UTC ℹ️ Start processing command /merge

2025-08-29 14:24:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-29 14:35:33 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 0cca741 into main Aug 29, 2025
222 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the therve/sqs branch August 29, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@therve @darccio @genesor