Skip to content

feat(ddtrace/tracer): Add 'endpoint' tag to API error metric#3925

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
ichinaski/stats-metrics-endpoint-tag
Aug 28, 2025
Merged

feat(ddtrace/tracer): Add 'endpoint' tag to API error metric#3925
dd-mergequeue[bot] merged 1 commit into
mainfrom
ichinaski/stats-metrics-endpoint-tag

Conversation

@ichinaski

@ichinaski ichinaski commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This metric is becoming part of the CSS spec, and having it tagged with the trace-agent endpoint will be useful for debugging purposes.

Motivation

See above

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@ichinaski
[APM] Add 'endpoint' tag to API error metric
1bc382c 
This metric is becoming part of the CSS spec, and having it tagged with
the trace-agent endpoint will be useful for debugging purposes.
@ichinaski
ichinaski requested a review from a team as a code owner August 28, 2025 11:46
@pr-commenter

pr-commenter Bot commented Aug 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-28 11:58:56

Comparing candidate commit 1bc382c in PR branch ichinaski/stats-metrics-endpoint-tag with baseline commit 35e1174 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@ichinaski ichinaski changed the title [APM] Add 'endpoint' tag to API error metric feat(ddtrace/tracer): Add 'endpoint' tag to API error metric Aug 28, 2025
darccio
darccio approved these changes Aug 28, 2025
View reviewed changes

@darccio darccio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ichinaski

ichinaski commented Aug 28, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 28, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-28 18:22:09 UTC ℹ️ Start processing command /merge

2025-08-28 18:22:17 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-28 18:38:56 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 105f1ef into main Aug 28, 2025
224 of 225 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the ichinaski/stats-metrics-endpoint-tag branch August 28, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ichinaski @darccio