feat(appsec): increase DD_APPSEC_WAF_TIMEOUT default value 1ms -> 2ms#3924
Merged
Conversation
Signed-off-by: Eliott Bouhana <[email protected]>
BenchmarksBenchmark execution time: 2025-08-27 14:52:34 Comparing candidate commit b576ef8 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
RomainMuller
approved these changes
Aug 27, 2025
eliottness
marked this pull request as ready for review
August 27, 2025 15:28
RomainMuller
approved these changes
Sep 19, 2025
Contributor
Author
|
/comment |
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
increase DD_APPSEC_WAF_TIMEOUT default value 1ms -> 2ms
Motivation
We believe the default timeout exclude too much customers from the security data they deserve and the current value ends up taking 0.3% of the requests of our customer where our goal should be around 1% so we believe to have to option to make it bigger for cases that matters
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!