fix(telemetry): data race between test and auto flush#3920
Merged
Conversation
Signed-off-by: Eliott Bouhana <[email protected]>
eliottness
marked this pull request as ready for review
August 27, 2025 11:23
kakkoyun
approved these changes
Aug 27, 2025
BenchmarksBenchmark execution time: 2025-08-27 11:31:55 Comparing candidate commit 5f167d7 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a mutex before flushing data from the telemetry client so only one at a time can happen
Motivation
This PR fixes the data races found here that could theoretically happen if somehow the main goroutine of a test ran slower than one full minute which would trigger auto flush before the actual writer was changed for the record writer and multiple small other things like this that are very unlikely to happen in real life
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!