ddtrace: add option to force SpanID#392
Merged
Merged
Conversation
willgittoes-dd
force-pushed
the
willgittoes-dd/span-id-option
branch
2 times, most recently
from
January 31, 2019 01:30
ef80980 to
0a106f3
Compare
willgittoes-dd
force-pushed
the
willgittoes-dd/span-id-option
branch
from
January 31, 2019 02:33
0a106f3 to
af959d6
Compare
palazzem
approved these changes
Jan 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use-case: I have a tracing "surrogate". I can't directly do tracing from the target application, so I have to build (I prefer in Golang) a surrogate that will create spans using information from the target application. That target still chooses the span/trace IDs, so that it can put them in headers. However the target cannot receive information from the tracer, so the tracer cannot be the one to choose the IDs. So therefore the tracing surrogate must create spans with IDs that are pre-decided by the target application.