Skip to content

chore(appsec): add tests for Forwarded header#3915

Merged
RomainMuller merged 1 commit into
mainfrom
romain.marcadier/APPSEC-58265/clientip.forwarded-tests
Aug 26, 2025
Merged

chore(appsec): add tests for Forwarded header#3915
RomainMuller merged 1 commit into
mainfrom
romain.marcadier/APPSEC-58265/clientip.forwarded-tests

Conversation

@RomainMuller

@RomainMuller RomainMuller commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Adds back the tests that were somehow missing from #3911.

Motivation

Tests are good.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@RomainMuller
RomainMuller requested a review from a team as a code owner August 26, 2025 10:51
@RomainMuller
RomainMuller force-pushed the romain.marcadier/APPSEC-58265/clientip.forwarded-tests branch from ef921bc to 5569da2 Compare August 26, 2025 10:53
@pr-commenter

pr-commenter Bot commented Aug 26, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-26 11:06:32

Comparing candidate commit 5569da2 in PR branch romain.marcadier/APPSEC-58265/clientip.forwarded-tests with baseline commit c921cdc in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@RomainMuller
RomainMuller merged commit baf19b9 into main Aug 26, 2025
242 checks passed
@RomainMuller
RomainMuller deleted the romain.marcadier/APPSEC-58265/clientip.forwarded-tests branch August 26, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RomainMuller @eliottness