Skip to content

feat(appsec): blocking on path params for net/http serve mux tracing#3914

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/blocking-on-path-params
Aug 27, 2025
Merged

feat(appsec): blocking on path params for net/http serve mux tracing#3914
dd-mergequeue[bot] merged 1 commit into
mainfrom
eliottness/blocking-on-path-params

Conversation

@eliottness

@eliottness eliottness commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR follows #3853 to finish the job and allow security rules to also block on path paramers and route being matched to a handler.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 25, 2025
@pr-commenter

pr-commenter Bot commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-25 13:38:56

Comparing candidate commit d7d99bc in PR branch eliottness/blocking-on-path-params with baseline commit b5536ad in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness
eliottness marked this pull request as ready for review August 27, 2025 08:26
@eliottness
eliottness requested review from a team as code owners August 27, 2025 08:26
@eliottness Graphite App

eliottness commented Aug 27, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 27, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-27 08:32:43 UTC ℹ️ Start processing command /merge

2025-08-27 08:32:48 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-27 08:46:16 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 0f71164 into main Aug 27, 2025
224 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/blocking-on-path-params branch August 27, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @darccio