Skip to content

feat(contrib/haproxy): Add HAProxy SPOE Agent binary#3913

Merged
dd-mergequeue[bot] merged 5 commits into
mainfrom
flavien/contrib/cmd/spoa
Oct 2, 2025
Merged

feat(contrib/haproxy): Add HAProxy SPOE Agent binary#3913
dd-mergequeue[bot] merged 5 commits into
mainfrom
flavien/contrib/cmd/spoa

Conversation

@e-n-0

@e-n-0 e-n-0 commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

This PR is the second part of the support of HAProxy with AAP. This part is creating the CLI package to be used to communicate with HAProxy using SPOE.

What does this PR do?

This CLI implements the haproxy spoe integration made in #3912.

The full installation instructions are described into the README.md file. The snippets that needs to be installed/configured into the haproxy configuration are located inside the haproxyconf folder.

Tests

The main binary and its new environment variables are unit tested

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@e-n-0
e-n-0 changed the base branch from main to flavien/contrib/haproxy August 25, 2025 13:20
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 25, 2025
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch 2 times, most recently from b701767 to e3b62d8 Compare August 25, 2025 13:23
@pr-commenter

pr-commenter Bot commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-10-02 14:55:41

Comparing candidate commit 0187539 in PR branch flavien/contrib/cmd/spoa with baseline commit ad0205e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@e-n-0
e-n-0 force-pushed the flavien/contrib/haproxy branch from 469c32d to 9ee5626 Compare August 25, 2025 13:29
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch 2 times, most recently from c61f014 to 0535995 Compare August 25, 2025 16:08
@e-n-0 e-n-0 changed the title contrib/haproxy: Add HAProxy SPOE Agent feat(contrib/haproxy): Add HAProxy SPOE Agent Aug 25, 2025
@e-n-0 e-n-0 changed the title feat(contrib/haproxy): Add HAProxy SPOE Agent feat(contrib/haproxy): Add HAProxy SPOE Agent binary Aug 25, 2025
@e-n-0 e-n-0 mentioned this pull request Aug 26, 2025
Merged
7 tasks
@e-n-0
e-n-0 force-pushed the flavien/contrib/haproxy branch from 6c40e5f to 5fce2b7 Compare September 8, 2025 16:08
@e-n-0
e-n-0 force-pushed the flavien/contrib/haproxy branch 2 times, most recently from fbcebc8 to cfdef7a Compare September 17, 2025 16:32
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch 2 times, most recently from b89b146 to 3e7de4a Compare September 19, 2025 11:43
@datadog-official

datadog-official Bot commented Sep 19, 2025 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 0187539 | Docs | Was this helpful? Give us feedback!

@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch 2 times, most recently from d1b24d6 to 0b2ffdc Compare September 19, 2025 15:29
@e-n-0
e-n-0 force-pushed the flavien/contrib/haproxy branch 2 times, most recently from 2664229 to d4759de Compare September 22, 2025 12:34
@e-n-0

e-n-0 commented Sep 22, 2025

Copy link
Copy Markdown
Member Author

@codex review

chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Sep 22, 2025
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment thread contrib/haproxy/stream-processing-offload/cmd/spoa/main.go
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch from 0b2ffdc to 8e19c42 Compare September 22, 2025 12:51
@e-n-0
e-n-0 force-pushed the flavien/contrib/haproxy branch from e3f93d7 to 46b0269 Compare September 24, 2025 09:24
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch 2 times, most recently from 78e2ee9 to a64c3bc Compare September 24, 2025 09:33
@e-n-0
e-n-0 force-pushed the flavien/contrib/haproxy branch from eec6d03 to 39c6213 Compare September 24, 2025 09:42
@e-n-0
e-n-0 force-pushed the flavien/contrib/cmd/spoa branch 2 times, most recently from c20e62f to 1888def Compare September 29, 2025 09:50
@e-n-0

e-n-0 commented Oct 2, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-02 15:27:53 UTC ℹ️ Start processing command /merge

2025-10-02 15:27:59 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-02 16:44:12 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 183c4b2:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@e-n-0

e-n-0 commented Oct 2, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-02 16:44:56 UTC ℹ️ Start processing command /merge

2025-10-02 16:45:01 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-02 18:14:39 UTC ℹ️ MergeQueue: The merge request ahead of this one was cancelled, retrying soon

2025-10-02 20:14:54 UTC ❌ MergeQueue: The build pipeline has timeout

The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'main' is 120 minutes.

@e-n-0

e-n-0 commented Oct 2, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-10-02 22:48:27 UTC ℹ️ Start processing command /merge

2025-10-02 22:48:31 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-02 23:38:39 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 5903b7d into main Oct 2, 2025
240 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the flavien/contrib/cmd/spoa branch October 2, 2025 23:38
@e-n-0 e-n-0 mentioned this pull request Oct 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e-n-0 @eliottness