Skip to content

ci: enable GOEXPERIMENT=synctest#3907

Merged
RomainMuller merged 8 commits into
mainfrom
eliottness/synctest
Aug 25, 2025
Merged

ci: enable GOEXPERIMENT=synctest#3907
RomainMuller merged 8 commits into
mainfrom
eliottness/synctest

Conversation

@eliottness

@eliottness eliottness commented Aug 21, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR enables the use of testing/synctest via the use of GOEXPERIMENT=synctest everywhere it makes sense while keeping a few places without it to make sure we don't do a release that would only work on it.

Motivation

Less flaky tests by using it instead of complex synchronisation primitives and unblocks #3897

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
ci: enable GOEXPERIMENT=synctest
bacc989 
Signed-off-by: Eliott Bouhana <[email protected]>
@pr-commenter

pr-commenter Bot commented Aug 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-22 14:12:23

Comparing candidate commit 3f761e1 in PR branch eliottness/synctest with baseline commit 389686a in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@datadog-official

datadog-official Bot commented Aug 21, 2025 •
edited by datadog-datadog-prod-us1 Bot
Loading

Copy link
Copy Markdown
Contributor

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3f761e1 | Docs | Was this helpful? Give us feedback!

@eliottness
add more env vars
f8a69f9 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
add more env vars
25c724d 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
add more env vars
0e84d8d 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
add todos
d46d1c2 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
unify synctest experiment and stable synctest api with an new package
a2a5446 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
fix build tag
42ec654 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
use defer instead of cleanup
3f761e1 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
eliottness marked this pull request as ready for review August 22, 2025 14:50
@eliottness
eliottness requested review from a team as code owners August 22, 2025 14:50
@RomainMuller
RomainMuller merged commit b5536ad into main Aug 25, 2025
249 of 254 checks passed
@RomainMuller
RomainMuller deleted the eliottness/synctest branch August 25, 2025 12:41
This was referenced Nov 14, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @RomainMuller