chore(internal/stacktrace): remove usage to eapache/queue/v2#3906
Conversation
Signed-off-by: Eliott Bouhana <[email protected]>
BenchmarksBenchmark execution time: 2025-08-21 15:23:43 Comparing candidate commit ea9d9db in PR branch Found 5 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 0 unstable metrics. scenario:BenchmarkCaptureStackTrace/10-24
scenario:BenchmarkCaptureStackTrace/100-24
scenario:BenchmarkCaptureStackTrace/20-24
scenario:BenchmarkCaptureStackTrace/200-24
scenario:BenchmarkCaptureStackTrace/50-24
|
|
/merge |
|
View all feedbacks in Devflow UI.
This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
The expected merge time in
|
Signed-off-by: Eliott Bouhana <[email protected]>
|
@eliottness The benchmark results are very curious. I think we'll have to optimize the implementation, as it feels like |
Signed-off-by: Eliott Bouhana <[email protected]>
eb470b3 to
ea9d9db
Compare
What does this PR do?
Remove our very poor usage of
github.com/eapache/queue/v2in favor or 5 more lines of codeMotivation
Reduce dd-trace-go dependency closure
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!