Skip to content

chore(internal/stacktrace): remove usage to eapache/queue/v2#3906

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
eliottness/remove-apache-equeue
Aug 21, 2025
Merged

chore(internal/stacktrace): remove usage to eapache/queue/v2#3906
dd-mergequeue[bot] merged 3 commits into
mainfrom
eliottness/remove-apache-equeue

Conversation

@eliottness

Copy link
Copy Markdown
Contributor

What does this PR do?

Remove our very poor usage of github.com/eapache/queue/v2 in favor or 5 more lines of code

Motivation

Reduce dd-trace-go dependency closure

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness
eliottness requested a review from a team as a code owner August 21, 2025 12:32
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 21, 2025
@pr-commenter

pr-commenter Bot commented Aug 21, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-21 15:23:43

Comparing candidate commit ea9d9db in PR branch eliottness/remove-apache-equeue with baseline commit 5fad65d in branch main.

Found 5 performance improvements and 5 performance regressions! Performance is the same for 5 metrics, 0 unstable metrics.

scenario:BenchmarkCaptureStackTrace/10-24

  • 🟥 allocated_mem [+1.372KB; +1.380KB] or [+17.578%; +17.690%]
  • 🟩 allocations [-17; -17] or [-32.075%; -32.075%]

scenario:BenchmarkCaptureStackTrace/100-24

  • 🟥 allocated_mem [+6.286KB; +6.360KB] or [+10.530%; +10.654%]
  • 🟩 allocations [-110; -110] or [-33.742%; -33.742%]

scenario:BenchmarkCaptureStackTrace/20-24

  • 🟥 allocated_mem [+2.098KB; +2.112KB] or [+15.728%; +15.833%]
  • 🟩 allocations [-26; -26] or [-31.707%; -31.707%]

scenario:BenchmarkCaptureStackTrace/200-24

  • 🟥 allocated_mem [+15.802KB; +15.890KB] or [+13.454%; +13.529%]
  • 🟩 allocations [-212; -212] or [-33.758%; -33.758%]

scenario:BenchmarkCaptureStackTrace/50-24

  • 🟥 allocated_mem [+3.795KB; +3.828KB] or [+12.621%; +12.730%]
  • 🟩 allocations [-58; -58] or [-33.333%; -33.333%]

@eliottness

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 21, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-21 13:06:49 UTC ℹ️ Start processing command /merge


2025-08-21 13:07:02 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-08-21 15:35:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).


2025-08-21 15:47:00 UTC ℹ️ MergeQueue: This merge request was merged

@darccio

darccio commented Aug 21, 2025

Copy link
Copy Markdown
Member

@eliottness The benchmark results are very curious. I think we'll have to optimize the implementation, as it feels like eapache/queue/v2 did something interesting that lead to less memory.

Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
eliottness force-pushed the eliottness/remove-apache-equeue branch from eb470b3 to ea9d9db Compare August 21, 2025 15:13
@dd-mergequeue
dd-mergequeue Bot merged commit 72ef80f into main Aug 21, 2025
243 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/remove-apache-equeue branch August 21, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants