Skip to content

fix: pin DataDog/datadog-go to v5.6.0 because of a breaking change in v5.7.0#3904

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
eliottness/replace-datadog-go
Aug 21, 2025
Merged

fix: pin DataDog/datadog-go to v5.6.0 because of a breaking change in v5.7.0#3904
dd-mergequeue[bot] merged 2 commits into
mainfrom
eliottness/replace-datadog-go

Conversation

@eliottness

@eliottness eliottness commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR is the result of DataDog/datadog-go#332

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness eliottness changed the title fix: pin DataDog/datadog-go to v5.6.0 becaue of a breaking change in v5.7.0 fix: pin DataDog/datadog-go to v5.6.0 because of a breaking change in v5.7.0 Aug 21, 2025
@eliottness
eliottness marked this pull request as ready for review August 21, 2025 08:21
@pr-commenter

pr-commenter Bot commented Aug 21, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-21 08:58:37

Comparing candidate commit 7d02e3f in PR branch eliottness/replace-datadog-go with baseline commit 547cf8f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness
replace all versions
7d02e3f 
Signed-off-by: Eliott Bouhana <[email protected]>
@eliottness
eliottness requested a review from darccio August 21, 2025 08:51
@eliottness

eliottness commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

/merge -p urgent

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 21, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-21 08:53:17 UTC ℹ️ Start processing command /merge -p urgent

2025-08-21 08:53:27 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-21 09:01:19 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-21 09:14:51 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 156fe4f into main Aug 21, 2025
243 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the eliottness/replace-datadog-go branch August 21, 2025 09:14
@eliottness eliottness mentioned this pull request Aug 21, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @darccio