Skip to content

refactor(internal/appsec): remove appsec-internal-go dependency#3899

Merged
RomainMuller merged 2 commits into
mainfrom
eliottness/remove-appsec-internal-go
Aug 27, 2025
Merged

refactor(internal/appsec): remove appsec-internal-go dependency#3899
RomainMuller merged 2 commits into
mainfrom
eliottness/remove-appsec-internal-go

Conversation

@eliottness

@eliottness eliottness commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

remove all last occurences to appsec-internal-go and run go mod tidy

Motivation

Deprecate appsec-internal-go

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Testscovering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.shlocally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

This was referenced Aug 20, 2025
Merged
Merged
@eliottness Graphite App

eliottness commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@eliottness eliottness mentioned this pull request Aug 20, 2025
Merged
9 tasks
@eliottness eliottness added the appsec label Aug 20, 2025 — with Graphite App
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 20, 2025
@pr-commenter

pr-commenter Bot commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-27 11:44:17

Comparing candidate commit 2719604 in PR branch eliottness/remove-appsec-internal-go with baseline commit c52da74 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 5 metrics, 0 unstable metrics.

scenario:BenchmarkStartSpanConfig/scenario_WithStartSpanConfig-24

  • 🟥 execution_time [+94.829ns; +112.771ns] or [+3.043%; +3.619%]

@eliottness
eliottness marked this pull request as ready for review August 20, 2025 15:50
@eliottness
eliottness requested review from a team as code owners August 20, 2025 15:50
@eliottness
eliottness force-pushed the eliottness/remove-appsec-internal-go branch from 39a809c to bf9bea7 Compare August 21, 2025 11:47
@eliottness
eliottness requested review from a team as code owners August 21, 2025 11:47
@eliottness
eliottness changed the base branch from eliottness/move-appsec-internal-config to graphite-base/3899 August 21, 2025 11:47
@eliottness
eliottness force-pushed the eliottness/remove-appsec-internal-go branch from bf9bea7 to f7dd97e Compare August 25, 2025 13:04
@eliottness
eliottness changed the base branch from graphite-base/3899 to eliottness/move-appsec-internal-config August 25, 2025 13:05
darccio
darccio approved these changes Aug 26, 2025
View reviewed changes

@darccio darccio left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice.

@eliottness
eliottness force-pushed the eliottness/move-appsec-internal-config branch from 39cecb0 to 4cb35b4 Compare August 26, 2025 11:52
@eliottness
eliottness force-pushed the eliottness/remove-appsec-internal-go branch from f7dd97e to b680620 Compare August 26, 2025 11:52
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 26, 2025 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2719604 | Docs | Was this helpful? Give us feedback!

@eliottness
eliottness force-pushed the eliottness/move-appsec-internal-config branch from 4cb35b4 to a8146a9 Compare August 26, 2025 12:56
@eliottness
eliottness force-pushed the eliottness/remove-appsec-internal-go branch 2 times, most recently from 1d4e609 to 146fb9c Compare August 27, 2025 11:00
Base automatically changed from eliottness/move-appsec-internal-config to main August 27, 2025 11:24
@eliottness
eliottness force-pushed the eliottness/remove-appsec-internal-go branch from 146fb9c to 2719604 Compare August 27, 2025 11:36
@RomainMuller
RomainMuller merged commit 54e8a39 into main Aug 27, 2025
242 checks passed
@RomainMuller
RomainMuller deleted the eliottness/remove-appsec-internal-go branch August 27, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs appsec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliottness @darccio @RomainMuller