Skip to content

refactor(internal/appsec): move appsec-internal-go config#3898

Merged
RomainMuller merged 8 commits into
mainfrom
eliottness/move-appsec-internal-config
Aug 27, 2025
Merged

refactor(internal/appsec): move appsec-internal-go config#3898
RomainMuller merged 8 commits into
mainfrom
eliottness/move-appsec-internal-config

Conversation

@eliottness

@eliottness eliottness commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Move appsec-internal-go/appsecconfig to the dd-trace-go config package
  • Start using the rules released in go-libddwaf instead of dd-trace-go

Motivation

Deprecate appsec-internal-go

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Testscovering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.shlocally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness eliottness mentioned this pull request Aug 20, 2025
Merged
7 tasks
@eliottness Graphite App

eliottness commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Aug 20, 2025
Merged
Merged
@eliottness eliottness added the appsec label Aug 20, 2025 — with Graphite App
@pr-commenter

pr-commenter Bot commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-27 11:05:38

Comparing candidate commit 31c5327 in PR branch eliottness/move-appsec-internal-config with baseline commit 9b7027e in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario:BenchmarkSampleWAFContext-24

  • 🟥 allocations [+6; +6] or [+3.529%; +3.529%]

@eliottness
eliottness marked this pull request as ready for review August 20, 2025 15:50
@eliottness
eliottness requested a review from a team as a code owner August 20, 2025 15:50
@eliottness
eliottness force-pushed the eliottness/move-appsec-internal-config branch from e251a1e to 772d808 Compare August 21, 2025 11:47
@eliottness
eliottness force-pushed the eliottness/move-apisec-sampler branch from 6dd52ef to d4c68c4 Compare August 21, 2025 11:47
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 21, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 31c5327 | Docs | Was this helpful? Give us feedback!

@eliottness
eliottness force-pushed the eliottness/move-appsec-internal-config branch from 772d808 to 39cecb0 Compare August 25, 2025 13:04
@eliottness
eliottness force-pushed the eliottness/move-appsec-internal-config branch from 39cecb0 to 4cb35b4 Compare August 26, 2025 11:52
@eliottness
eliottness force-pushed the eliottness/move-apisec-sampler branch from b821cbe to c0b245a Compare August 26, 2025 11:52
@eliottness
eliottness force-pushed the eliottness/move-appsec-internal-config branch from 4cb35b4 to a8146a9 Compare August 26, 2025 12:56
@eliottness
eliottness force-pushed the eliottness/move-apisec-sampler branch from c0b245a to 1d2afb8 Compare August 26, 2025 12:56
Base automatically changed from eliottness/move-apisec-sampler to main August 27, 2025 08:49
@RomainMuller
RomainMuller requested a review from a team as a code owner August 27, 2025 09:27
@RomainMuller
RomainMuller enabled auto-merge (squash) August 27, 2025 09:49
github-advanced-security[bot]
github-advanced-security AI found potential problems Aug 27, 2025
View reviewed changes
Comment thread internal/appsec/config/config.go Fixed
@eliottness
eliottness force-pushed the eliottness/move-appsec-internal-config branch from 4ac7f1c to 31c5327 Compare August 27, 2025 11:00
@eliottness Graphite App

eliottness commented Aug 27, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 27, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-27 11:19:01 UTC ℹ️ Start processing command /merge

2025-08-27 11:19:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-27 11:24:12 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@RomainMuller
RomainMuller merged commit c52da74 into main Aug 27, 2025
243 checks passed
@RomainMuller
RomainMuller deleted the eliottness/move-appsec-internal-config branch August 27, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

appsec mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliottness @RomainMuller @github-advanced-security