Skip to content

refactor(internal/appsec): move appsec-internal-go/limiter#3896

Merged
RomainMuller merged 1 commit into
mainfrom
eliottness/move-limiter
Aug 25, 2025
Merged

refactor(internal/appsec): move appsec-internal-go/limiter#3896
RomainMuller merged 1 commit into
mainfrom
eliottness/move-limiter

Conversation

@eliottness

@eliottness eliottness commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Move limiter.Limiter from appsec-internal-go to dd-trace-go

Motivation

Deprecate appsec-internal-go

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Testscovering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.shlocally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@eliottness Graphite App

eliottness commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Aug 20, 2025
Merged
Merged
Merged
@eliottness eliottness added the appsec label Aug 20, 2025 — with Graphite App
@pr-commenter

pr-commenter Bot commented Aug 20, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-21 12:04:09

Comparing candidate commit 29f5ebe in PR branch eliottness/move-limiter with baseline commit 5fad65d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@eliottness
eliottness marked this pull request as ready for review August 20, 2025 15:50
@eliottness
eliottness requested a review from a team as a code owner August 20, 2025 15:50
@eliottness
eliottness force-pushed the eliottness/move-limiter branch from 2d1e87f to 29f5ebe Compare August 21, 2025 11:47
@RomainMuller
RomainMuller merged commit d59db7e into main Aug 25, 2025
242 checks passed
@RomainMuller
RomainMuller deleted the eliottness/move-limiter branch August 25, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

appsec

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eliottness @RomainMuller