feat(contrib/aws/sqs): add cloud.resource_id as resource tag#3894
Merged
Conversation
github-actions
Bot
added
the
apm:ecosystem
seungleelee
marked this pull request as ready for review
August 19, 2025 17:47
seungleelee
changed the title
BenchmarksBenchmark execution time: 2025-08-28 21:01:00 Comparing candidate commit 0aaf27e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics. |
darccio
requested changes
Aug 26, 2025
seungleelee
force-pushed
the
seunglee/add-sqs-queueurl-tag
branch
from
August 28, 2025 20:44
905443b to
0aaf27e
Compare
darccio
approved these changes
Aug 29, 2025
Member
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
This was referenced Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR attaches a
cloud.resource_idtag to AWS SQS traces with the sqs arn as the value, derived from thequeueURL- this is already available within the tracer since the queue url is a parameter to the SQS operations via AWS SDK.Motivation
Part of a larger effort to better link cloud resources within Datadog. Currently the way in which sqs resources are tagged are inconsistent across different trace libraries, and we need a consistent tag key with the same value format to support this linkage.
Jira Ticket and more context around this effort
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!