Skip to content

DRAFT: Help #3856#3890

Merged
darccio merged 1 commit into
dario.castane/incident-41436/apmapi-1545from
mtoff/incident-41436/apmapi-1545
Aug 19, 2025
Merged

DRAFT: Help #3856#3890
darccio merged 1 commit into
dario.castane/incident-41436/apmapi-1545from
mtoff/incident-41436/apmapi-1545

Conversation

@mtoffl01

@mtoffl01 mtoffl01 commented Aug 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Updates the logic for testing spanContext.updated field

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@mtoffl01
mtoffl01 requested a review from a team as a code owner August 18, 2025 21:03
@mtoffl01
mtoffl01 marked this pull request as draft August 18, 2025 21:04
@mtoffl01
mtoffl01 changed the base branch from main to dario.castane/incident-41436/apmapi-1545 August 18, 2025 21:04
@mtoffl01
mtoffl01 requested a review from darccio August 18, 2025 21:05
@pr-commenter

pr-commenter Bot commented Aug 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-18 21:19:37

Comparing candidate commit d31e6b9 in PR branch mtoff/incident-41436/apmapi-1545 with baseline commit 18f6913 in branch dario.castane/incident-41436/apmapi-1545.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@mtoffl01 mtoffl01 mentioned this pull request Aug 18, 2025
Merged
7 tasks
@darccio
darccio marked this pull request as ready for review August 19, 2025 07:50
@darccio
darccio merged commit ea94a70 into dario.castane/incident-41436/apmapi-1545 Aug 19, 2025
223 of 224 checks passed
@darccio
darccio deleted the mtoff/incident-41436/apmapi-1545 branch August 19, 2025 07:50
@darccio

darccio commented Aug 19, 2025

Copy link
Copy Markdown
Member

Duplicating this PR as rebasing main into the PR branch - without pulling the merge commit for this PR - caused the changes to be lost.

Fortunately it's to keep the tests sane, and it doesn't impact functionality.

darccio pushed a commit that referenced this pull request Aug 19, 2025
@mtoffl01 @darccio
DRAFT: Help #3856 (#3890)
1d3f24a
@darccio darccio mentioned this pull request Aug 19, 2025
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtoffl01 @darccio