chore: prevent smoke tests from failing-fast#3888
Merged
Merged
Conversation
BenchmarksBenchmark execution time: 2025-08-18 18:28:06 Comparing candidate commit 4f057a4 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 23 metrics, 1 unstable metrics. |
hannahkm
marked this pull request as ready for review
August 18, 2025 18:43
darccio
approved these changes
Aug 19, 2025
Member
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
dd-devflow
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
fail-fast: falseto smoke tests running contribs.Motivation
Previously, failing one contrib test would cause all contrib smoke tests to be cancelled and end early. This prevents us from seeing other failures that might exist.
Reviewer's Checklist
./scripts/lint.shlocally.Unsure? Have a question? Request a review!