Skip to content

contrib/go-redis/redis: fix context race in client#388

Merged
gbbr merged 1 commit into
v1from
gbbr/race-redis
Jan 28, 2019
Merged

contrib/go-redis/redis: fix context race in client#388
gbbr merged 1 commit into
v1from
gbbr/race-redis

Conversation

@gbbr

@gbbr gbbr commented Jan 28, 2019

Copy link
Copy Markdown
Contributor

Fixes a race condition when using the client concurrently with WithContext.

Fixes #387

@gbbr gbbr added this to the next milestone Jan 28, 2019
This change fixes a race condition occurring when querying a client in
parallel with changing its context.
@gbbr gbbr added bug unintended behavior that has to be fixed and removed do-not-merge/WIP labels Jan 28, 2019

@raphaelgavache raphaelgavache left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtm

@gbbr
gbbr merged commit 61d8c99 into v1 Jan 28, 2019
@gbbr
gbbr deleted the gbbr/race-redis branch January 28, 2019 14:40
gbbr added a commit that referenced this pull request Jan 29, 2019
@gbbr gbbr modified the milestones: next, 1.9.0 Jan 29, 2019
mingrammer pushed a commit to mingrammer/dd-trace-go that referenced this pull request Dec 22, 2020
This change fixes a race condition occurring when querying a client in
parallel with changing its context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug unintended behavior that has to be fixed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants