Skip to content

chore(ci/orchestrion): just set GOWORK=off#3879

Merged
RomainMuller merged 2 commits into
mainfrom
romain.marcadier/ci-fix-win-replace
Aug 13, 2025
Merged

chore(ci/orchestrion): just set GOWORK=off#3879
RomainMuller merged 2 commits into
mainfrom
romain.marcadier/ci-fix-win-replace

Conversation

@RomainMuller

Copy link
Copy Markdown
Contributor

Motivation

Unless doing this, the go work use may contain duplicated delimiters (// or \\) while the -replace directive saves the clean path, resulting in an error.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

Unless doing this, the `go work use` may contain duplicated delimiters (`//` or `\\`)
while the `-replace` directive saves the clean path, resulting in an error.
@RomainMuller
RomainMuller requested a review from a team as a code owner August 13, 2025 15:56
@pr-commenter

pr-commenter Bot commented Aug 13, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-13 17:00:27

Comparing candidate commit 5b134a5 in PR branch romain.marcadier/ci-fix-win-replace with baseline commit f0fb69d in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@RomainMuller RomainMuller changed the title chore(ci/orchestrion): canonicalize path before go work use chore(ci/orchestrion): just set GOWORK=off Aug 13, 2025
@RomainMuller
RomainMuller enabled auto-merge (squash) August 13, 2025 16:34
@RomainMuller
RomainMuller force-pushed the romain.marcadier/ci-fix-win-replace branch from 793074e to e73360d Compare August 13, 2025 16:39
@RomainMuller
RomainMuller requested a review from a team as a code owner August 13, 2025 16:39
@RomainMuller
RomainMuller force-pushed the romain.marcadier/ci-fix-win-replace branch from e73360d to 5b134a5 Compare August 13, 2025 16:46
@RomainMuller
RomainMuller merged commit e4a3652 into main Aug 13, 2025
309 of 311 checks passed
@RomainMuller
RomainMuller deleted the romain.marcadier/ci-fix-win-replace branch August 13, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants