Skip to content

fix(orchestrion/ci): use backslash in replace directive on Windows#3878

Merged
RomainMuller merged 1 commit into
mainfrom
romain.marcadier/ci-fix-win-replace
Aug 13, 2025
Merged

fix(orchestrion/ci): use backslash in replace directive on Windows#3878
RomainMuller merged 1 commit into
mainfrom
romain.marcadier/ci-fix-win-replace

Conversation

@RomainMuller

Copy link
Copy Markdown
Contributor

Motivation

Otherwise the go.work use path and -replace directives are not identical, and this results in an error.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@RomainMuller
RomainMuller requested a review from a team as a code owner August 13, 2025 14:59
@pr-commenter

pr-commenter Bot commented Aug 13, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-13 15:11:23

Comparing candidate commit f892431 in PR branch romain.marcadier/ci-fix-win-replace with baseline commit 0f4e32c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@RomainMuller
RomainMuller merged commit f0fb69d into main Aug 13, 2025
222 checks passed
@RomainMuller
RomainMuller deleted the romain.marcadier/ci-fix-win-replace branch August 13, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants