Skip to content

chore(ci/orchestrion): add orchestrion checkout to go.work#3877

Merged
RomainMuller merged 3 commits into
mainfrom
romain.marcadier/ci-fix-go-work
Aug 13, 2025
Merged

chore(ci/orchestrion): add orchestrion checkout to go.work#3877
RomainMuller merged 3 commits into
mainfrom
romain.marcadier/ci-fix-go-work

Conversation

@RomainMuller

Copy link
Copy Markdown
Contributor

What does this PR do?

The go directive in the go.work file must be set to the highest of all used modules. This is a problem when orchestrion changes its own go directive forward before dd-trace-go does, and is fixed by adding it to the workspace.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

The `go` directive in the `go.work` file must be set to the highest of all used modules. This is a problem when orchestrion changes its own `go` directive forward before `dd-trace-go` does, and is fixed by adding it to the workspace.
@RomainMuller
RomainMuller requested a review from a team as a code owner August 13, 2025 13:54
@RomainMuller RomainMuller changed the title chore(ci/orchestrion): add orchestrion checkout to go.work chore(ci/orchestrion): add orchestrion checkout to go.work Aug 13, 2025
@pr-commenter

pr-commenter Bot commented Aug 13, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-13 14:38:01

Comparing candidate commit fee7e23 in PR branch romain.marcadier/ci-fix-go-work with baseline commit 1b48b97 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

Comment thread .github/workflows/orchestrion.yml
@RomainMuller
RomainMuller requested a review from a team as a code owner August 13, 2025 14:15
@RomainMuller
RomainMuller merged commit 0f4e32c into main Aug 13, 2025
231 of 233 checks passed
@RomainMuller
RomainMuller deleted the romain.marcadier/ci-fix-go-work branch August 13, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants