Skip to content

chore(ci/orchestrion): integration tests break if orchestrion updates go directive#3874

Merged
RomainMuller merged 1 commit into
mainfrom
romain.marcadier/fix-orchestrion-integ-go-pin
Aug 13, 2025
Merged

chore(ci/orchestrion): integration tests break if orchestrion updates go directive#3874
RomainMuller merged 1 commit into
mainfrom
romain.marcadier/fix-orchestrion-integ-go-pin

Conversation

@RomainMuller

Copy link
Copy Markdown
Contributor

What does this PR do?

Removes the -go constraint on the go mod commands in the CI setup so that the toolchain can update the go directive appropriately when orchestrion and dd-trace-go have different Go runtime requirirements.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

… go directive

Removes the `-go` constraint on the `go mod` commands in the CI setup so that the toolchain can update the `go` directive appropriately when `orchestrion` and `dd-trace-go` have different Go runtime requirirements.
@pr-commenter

pr-commenter Bot commented Aug 13, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-13 09:59:10

Comparing candidate commit 686fa38 in PR branch romain.marcadier/fix-orchestrion-integ-go-pin with baseline commit 66aa2dd in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@RomainMuller
RomainMuller enabled auto-merge (squash) August 13, 2025 12:45
@RomainMuller
RomainMuller merged commit 9ead3c1 into main Aug 13, 2025
303 of 312 checks passed
@RomainMuller
RomainMuller deleted the romain.marcadier/fix-orchestrion-integ-go-pin branch August 13, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants