Skip to content

ci: conventional commits PR naming#3873

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
ben.db/conventionnal-commits-pr
Aug 13, 2025
Merged

ci: conventional commits PR naming#3873
dd-mergequeue[bot] merged 3 commits into
mainfrom
ben.db/conventionnal-commits-pr

Conversation

@genesor

@genesor genesor commented Aug 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

Enforce a new format for our PR naming following conventional commit guidelines

Example of a failing job & successful job

Motivation

This topic was discussed and validated during a guild meeting

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@genesor
genesor force-pushed the ben.db/conventionnal-commits-pr branch from 3efe250 to 0ed9e18 Compare August 13, 2025 09:09
@genesor genesor changed the title conventional commits PR naming ci: conventional commits PR naming Aug 13, 2025
@genesor
genesor force-pushed the ben.db/conventionnal-commits-pr branch from 0ed9e18 to c24554c Compare August 13, 2025 09:12
@pr-commenter

pr-commenter Bot commented Aug 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-13 12:35:23

Comparing candidate commit d9afc17 in PR branch ben.db/conventionnal-commits-pr with baseline commit c0cbb8f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@genesor
genesor marked this pull request as ready for review August 13, 2025 09:12
@genesor
genesor requested a review from a team as a code owner August 13, 2025 09:12
@genesor

genesor commented Aug 13, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 13, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-13 13:03:07 UTC ℹ️ Start processing command /merge

2025-08-13 13:03:14 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-13 13:13:46 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 1b48b97 into main Aug 13, 2025
310 of 313 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the ben.db/conventionnal-commits-pr branch August 13, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@genesor @darccio