Skip to content

fix(scripts): fix fix_modules.sh script#3870

Merged
dd-mergequeue[bot] merged 4 commits into
mainfrom
rarguelloF/fix-scripts
Aug 25, 2025
Merged

fix(scripts): fix fix_modules.sh script#3870
dd-mergequeue[bot] merged 4 commits into
mainfrom
rarguelloF/fix-scripts

Conversation

@rarguelloF

@rarguelloF rarguelloF commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

The first line on the scripts/fix_modules.sh:

go run -tags=scripts ./scripts/fixmodules -root=. .

was silently failing with the following error:

main module (github.com/DataDog/dd-trace-go/v2) does not contain package github.com/DataDog/dd-trace-go/v2/scripts/fixmodule

This is because the fixmodules go script was moved to a go module but was not added to the go.work file.

Updated the go.work file with the missing modules and updated the bash script to ensure it does not silently fail in the future.

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@rarguelloF
rarguelloF requested a review from a team as a code owner August 12, 2025 15:05
@pr-commenter

pr-commenter Bot commented Aug 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-25 09:41:53

Comparing candidate commit 299e8f0 in PR branch rarguelloF/fix-scripts with baseline commit 72ef80f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

darccio
darccio requested changes Aug 12, 2025
View reviewed changes
Comment thread go.work Outdated
kakkoyun
kakkoyun requested changes Aug 12, 2025
View reviewed changes
Comment thread scripts/fix_modules.sh
Comment thread scripts/fixmodules/main.go
@rarguelloF
rarguelloF requested review from darccio and kakkoyun August 19, 2025 12:13
@rarguelloF

rarguelloF commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 19, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-19 13:20:31 UTC ℹ️ Start processing command /merge

2025-08-19 13:20:43 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-19 17:21:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@rarguelloF

rarguelloF commented Aug 25, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-25 09:43:16 UTC ℹ️ Start processing command /merge

2025-08-25 09:43:27 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-25 09:44:14 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-25 09:57:43 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit eb9097d into main Aug 25, 2025
222 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the rarguelloF/fix-scripts branch August 25, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rarguelloF @darccio @kakkoyun