Skip to content

ci: fix docker images releases#3867

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
flavien/fix-docker-releases
Aug 12, 2025
Merged

ci: fix docker images releases#3867
dd-mergequeue[bot] merged 1 commit into
mainfrom
flavien/fix-docker-releases

Conversation

@e-n-0

@e-n-0 e-n-0 commented Aug 12, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR removes the installation of Docker inside the arm64 runner.

Motivation

The release of the docker images linked to the release of the go tracer failed. The job building running in the arm64 runner was failing when installing docker. This was previously required because we were using the runner image arm-4core-linux and it has been changed to use ubuntu-24.04-arm in this PR.
However now in the new runner, docker is already installed by default (everything listed here).

This issue was not detected before while building and running the system tests because the system tests are running exclusively on amd64, skipping the arm64 build step.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@e-n-0
e-n-0 force-pushed the flavien/fix-docker-releases branch from bd60bd7 to ebb6277 Compare August 12, 2025 11:05
@pr-commenter

pr-commenter Bot commented Aug 12, 2025

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-12 11:22:49

Comparing candidate commit c1a163e in PR branch flavien/fix-docker-releases with baseline commit 4d47dd6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@e-n-0
e-n-0 force-pushed the flavien/fix-docker-releases branch from b07541c to c1a163e Compare August 12, 2025 11:10
@e-n-0 e-n-0 changed the title test ci: fix docker images releases Aug 12, 2025
@e-n-0
e-n-0 marked this pull request as ready for review August 12, 2025 11:17
@e-n-0
e-n-0 requested a review from a team as a code owner August 12, 2025 11:17
@e-n-0

e-n-0 commented Aug 12, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 12, 2025

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-12 11:30:35 UTC ℹ️ Start processing command /merge


2025-08-12 11:30:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).


2025-08-12 11:44:11 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 3985af7 into main Aug 12, 2025
224 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the flavien/fix-docker-releases branch August 12, 2025 11:44
e-n-0 added a commit that referenced this pull request Aug 12, 2025
e-n-0 added a commit that referenced this pull request Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants