Skip to content

chore: upgrade github.com/DataDog/go-libddwaf/v4 to v4.3.2#3858

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
romain.marcadier/incident-41724/upgrade-go-libddwaf
Aug 8, 2025
Merged

chore: upgrade github.com/DataDog/go-libddwaf/v4 to v4.3.2#3858
dd-mergequeue[bot] merged 1 commit into
mainfrom
romain.marcadier/incident-41724/upgrade-go-libddwaf

Conversation

@RomainMuller

@RomainMuller RomainMuller commented Aug 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

This addresses an issue that can lead to kernel panics or spontaneous reboots on macOS hosts with an Apple M4 chip and macOS 15.

Fixes #3827

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@RomainMuller
chore: upgrade github.com/DataDog/go-libddwaf/v4 to v4.3.2
0ec08f8 
This addresses an issue that can lead to kernel panics or spontaneous reboots on
macOS hosts with an Apple M4 chip and macOS 15.
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 8, 2025
@pr-commenter

pr-commenter Bot commented Aug 8, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-08 08:33:23

Comparing candidate commit 0ec08f8 in PR branch romain.marcadier/incident-41724/upgrade-go-libddwaf with baseline commit 4c620a2 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio

darccio commented Aug 8, 2025

Copy link
Copy Markdown
Member

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 8, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-08 08:48:30 UTC ℹ️ Start processing command /merge

2025-08-08 08:48:37 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 13m (p90).

2025-08-08 08:59:03 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 711cdf7 into main Aug 8, 2025
248 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the romain.marcadier/incident-41724/upgrade-go-libddwaf branch August 8, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@kakkoyun kakkoyun kakkoyun approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: opentelemetry.NewTraceProvider causes kernel panic on macOS

3 participants

@RomainMuller @darccio @kakkoyun