Skip to content

chore: upgrade gofiber/fiber to v2.52.9 to avoid crashes#3854

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
hannahkm/upgrade-gofiber
Aug 7, 2025
Merged

chore: upgrade gofiber/fiber to v2.52.9 to avoid crashes#3854
dd-mergequeue[bot] merged 3 commits into
mainfrom
hannahkm/upgrade-gofiber

Conversation

@hannahkm

@hannahkm hannahkm commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

What does this PR do?

Upgrades gofiber/fiber to v2.52.9

Motivation

https://github.com/DataDog/dd-trace-go/security/dependabot/292

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 6, 2025
kakkoyun
kakkoyun reviewed Aug 7, 2025
View reviewed changes
Comment thread go.work Outdated
@pr-commenter

pr-commenter Bot commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-07 15:25:50

Comparing candidate commit defa4bd in PR branch hannahkm/upgrade-gofiber with baseline commit 3aac4d6 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@hannahkm

hannahkm commented Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-07 17:18:53 UTC ℹ️ Start processing command /merge

2025-08-07 17:19:02 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-07 17:29:37 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 4c620a2 into main Aug 7, 2025
245 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the hannahkm/upgrade-gofiber branch August 7, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun left review comments
@RomainMuller RomainMuller RomainMuller approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hannahkm @RomainMuller @kakkoyun