feat: resource renaming by e-n-0 · Pull Request #3851 · DataDog/dd-trace-go

e-n-0 · 2025-08-05T12:31:21Z

What does this PR do?

This PR implements:

This PR:

Upgrades the module github.com/DataDog/datadog-agent/pkg/trace to v0.71.0
- Use the new method NewStatSpanWithConfig (using httpMethod and httpEndpoint) implemented from trace/stats: Add HTTP Method and Endpoint for resource renaming datadog-agent#39372 for stats computation
Implements the new http.endpoint tag
Implements two new environment variables:
- DD_TRACE_RESOURCE_RENAMING_ENABLED
- DD_TRACE_RESOURCE_RENAMING_ALWAYS_SIMPLIFIED_ENDPOINT
Always use the new simplification algorithm using the url for the API Security sampler key if no route nor http.endpoint are set.

Tests

Unit tests

Unit tests have been implemented for:

stats aggregation
route simplification algorithm
http.endpoint data based on the http.route presence
computed API Security sampler key based on the http.route and http.endpoint presence

System tests

This PR have been tested against the system tests for resource renaming:

Additional information

A PR has been drafted in the dd-source repository that upgrade of the datadog-agent dependency to facilitate the next release that includes these changes.
https://github.com/DataDog/dd-source/pull/291666

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
There is a benchmark for any new code, or changes to existing code.
If this interacts with the agent in a new way, a system test has been added.
New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
Add an appropriate team label so this PR gets put in the right place for the release notes.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

pr-commenter · 2025-08-07T14:45:30Z

Benchmarks

Benchmark execution time: 2025-10-21 12:52:20

Comparing candidate commit f2c1502 in PR branch flavien/resource-renaming with baseline commit e1b2c3b in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario:BenchmarkInjectW3C-24

🟥 execution_time [+110.844ns; +141.756ns] or [+2.823%; +3.610%]

datadog-official · 2025-10-03T16:26:43Z

⚠️ Tests

⚠️ Warnings

❄️ 2 New flaky tests detected

TestReportAbandonedSpans from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog)
Failed

=== RUN   TestReportAbandonedSpans
--- FAIL: TestReportAbandonedSpans (1.19s)
TestReportAbandonedSpans/wait from github.com/DataDog/dd-trace-go/v2/ddtrace/tracer (Datadog)
Failed

=== RUN   TestReportAbandonedSpans/wait
    abandonedspans_test.go:307: 
        	Error Trace:	D:/a/dd-trace-go/dd-trace-go/ddtrace/tracer/abandonedspans_test.go:307
        	Test:       	TestReportAbandonedSpans/wait
    --- FAIL: TestReportAbandonedSpans/wait (0.11s)

ℹ️ Info

🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: f2c1502 | Docs | Was this helpful? Give us feedback!}

genesor

LGTM, I have some questions

genesor · 2025-10-20T14:23:59Z

+		}
+
+		sc.Tags[ext.HTTPEndpoint] = endpoint
+		serveCfg.Endpoint = endpoint


It feel a bit weird to update the ServeConfig in a StartSpanOption.

It seems that the only place where Endpoint is used is is in renamedRoute, couldn't we read the tag from the span there instead of the config?

I did that because we don't have access to the span tag (outside of the tracer.StartSpanConfig), or i'm missing something?

I changed the behavior in f2c1502, it doesn't use ServeConfig anymore to get/set the Endpoint. Let me know if you prefer this solution

e-n-0 · 2025-10-22T13:39:43Z

/merge

dd-devflow-routing-codex · 2025-10-22T13:39:48Z

View all feedbacks in Devflow UI.

2025-10-22 13:39:48 UTC ℹ️ Start processing command /merge

2025-10-22 13:39:53 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-22 13:57:04 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 281945b:

unit-integration-tests / test-core

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

e-n-0 · 2025-10-22T13:59:10Z

/merge

dd-devflow-routing-codex · 2025-10-22T13:59:15Z

View all feedbacks in Devflow UI.

2025-10-22 13:59:14 UTC ℹ️ Start processing command /merge

2025-10-22 13:59:22 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-22 14:18:55 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit 4b84e91:

unit-integration-tests / test-core

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

e-n-0 · 2025-10-22T14:25:33Z

/merge

dd-devflow-routing-codex · 2025-10-22T14:25:38Z

View all feedbacks in Devflow UI.

2025-10-22 14:25:37 UTC ℹ️ Start processing command /merge

2025-10-22 14:25:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-10-22 14:38:59 UTC ℹ️ MergeQueue: This merge request was merged

e-n-0 mentioned this pull request Aug 5, 2025

trace/stats: Add HTTP Method and Endpoint for resource renaming DataDog/datadog-agent#39372

Merged

e-n-0 force-pushed the flavien/resource-renaming branch from 455fe3e to a5c1dd2 Compare August 7, 2025 16:05

e-n-0 force-pushed the flavien/resource-renaming branch from 6357975 to 1865294 Compare August 25, 2025 12:28

e-n-0 force-pushed the flavien/resource-renaming branch from 1865294 to 3e577f7 Compare October 3, 2025 16:19

e-n-0 force-pushed the flavien/resource-renaming branch 3 times, most recently from 1a693b2 to 3b02665 Compare October 13, 2025 15:47

github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Oct 15, 2025

e-n-0 force-pushed the flavien/resource-renaming branch 11 times, most recently from b8cd349 to 9203a91 Compare October 20, 2025 08:32

e-n-0 marked this pull request as ready for review October 20, 2025 11:10

e-n-0 requested review from a team as code owners October 20, 2025 11:10

e-n-0 marked this pull request as draft October 20, 2025 11:34

e-n-0 marked this pull request as ready for review October 20, 2025 12:52

genesor reviewed Oct 20, 2025

View reviewed changes

e-n-0 force-pushed the flavien/resource-renaming branch from c034620 to cc5f3ce Compare October 20, 2025 16:18

genesor approved these changes Oct 21, 2025

View reviewed changes

e-n-0 added 3 commits October 21, 2025 14:45

some optimizations

f6c7de4

update activation comment

053f612

remove Endpoint in ServeConfig

f2c1502

e-n-0 force-pushed the flavien/resource-renaming branch from 1fba641 to f2c1502 Compare October 21, 2025 12:45

darccio approved these changes Oct 22, 2025

View reviewed changes

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: queued mergequeue-status: in_progress labels Oct 22, 2025

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: rejected mergequeue-status: queued mergequeue-status: in_progress labels Oct 22, 2025

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: rejected mergequeue-status: queued labels Oct 22, 2025

dd-mergequeue Bot merged commit 9668c9a into main Oct 22, 2025
301 of 307 checks passed

dd-mergequeue Bot deleted the flavien/resource-renaming branch October 22, 2025 14:38

dd-devflow Bot added mergequeue-status: done and removed mergequeue-status: in_progress labels Oct 22, 2025

Uh oh!

Conversation

e-n-0 commented Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Tests

Unit tests

System tests

Additional information

Reviewer's Checklist

Uh oh!

pr-commenter Bot commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

scenario:BenchmarkInjectW3C-24

Uh oh!

datadog-official Bot commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

genesor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

genesor Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

e-n-0 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

e-n-0 Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

e-n-0 commented Oct 22, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

e-n-0 commented Oct 22, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

e-n-0 commented Oct 22, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

e-n-0 commented Aug 5, 2025 •

edited

Loading

pr-commenter Bot commented Aug 7, 2025 •

edited

Loading

datadog-official Bot commented Oct 3, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Oct 22, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Oct 22, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Oct 22, 2025 •

edited

Loading