Skip to content

feat(ddtrace/tracer): add DD_TRACE_AGENT_PROTOCOL_VERSION support#3850

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
dario.castane/langplat-708/v1-trace-protocol-switch-2
Aug 11, 2025
Merged

feat(ddtrace/tracer): add DD_TRACE_AGENT_PROTOCOL_VERSION support#3850
dd-mergequeue[bot] merged 3 commits into
mainfrom
dario.castane/langplat-708/v1-trace-protocol-switch-2

Conversation

@darccio

@darccio darccio commented Aug 5, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Adds DD_TRACE_AGENT_PROTOCOL_VERSION option to support v1 trace protocol.

This is aligned with Node.js tracer.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@darccio
darccio requested a review from a team as a code owner August 5, 2025 10:32
@pr-commenter

pr-commenter Bot commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-08 09:25:22

Comparing candidate commit 789cba2 in PR branch dario.castane/langplat-708/v1-trace-protocol-switch-2 with baseline commit 2be700c in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

genesor
genesor approved these changes Aug 5, 2025
View reviewed changes
Comment thread ddtrace/tracer/payload.go Outdated
kakkoyun
kakkoyun reviewed Aug 5, 2025
View reviewed changes
Comment thread ddtrace/tracer/option.go
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 789cba2 | Docs | Was this helpful? Give us feedback!

@darccio
darccio force-pushed the dario.castane/langplat-708/v1-trace-protocol-switch-2 branch from e8cc577 to 78cf154 Compare August 5, 2025 10:48
hannahkm
hannahkm reviewed Aug 7, 2025
View reviewed changes
Comment thread ddtrace/tracer/option.go Outdated
@darccio
darccio force-pushed the dario.castane/langplat-708/v1-trace-protocol-switch-2 branch from 78cf154 to 5b1bd14 Compare August 8, 2025 09:09
@darccio
darccio requested review from hannahkm and kakkoyun August 8, 2025 09:10
@darccio
darccio force-pushed the dario.castane/langplat-708/v1-trace-protocol-switch-2 branch from 5b1bd14 to 789cba2 Compare August 8, 2025 09:12
kakkoyun
kakkoyun approved these changes Aug 11, 2025
View reviewed changes

@kakkoyun kakkoyun left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@darccio

darccio commented Aug 11, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 11, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-11 09:11:13 UTC ℹ️ Start processing command /merge

2025-08-11 09:11:22 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-11 09:22:14 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 13m (p90).

2025-08-11 09:36:42 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit a99b459 into main Aug 11, 2025
294 of 296 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the dario.castane/langplat-708/v1-trace-protocol-switch-2 branch August 11, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun approved these changes
@genesor genesor genesor approved these changes
@hannahkm hannahkm hannahkm approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@darccio @kakkoyun @genesor @hannahkm