Skip to content

chore(contrib/envoy): tests for config for serviceextensions#3848

Merged
dd-mergequeue[bot] merged 2 commits into
mainfrom
flavien/envoy/config-tests
Aug 5, 2025
Merged

chore(contrib/envoy): tests for config for serviceextensions#3848
dd-mergequeue[bot] merged 2 commits into
mainfrom
flavien/envoy/config-tests

Conversation

@e-n-0

@e-n-0 e-n-0 commented Aug 4, 2025

Copy link
Copy Markdown
Member

What does this PR do?

Add tests for the configuration for the serviceextensions.

Motivation

More QA + project to disallow all unknown env var if they are not present in a list from @genesor

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@e-n-0
e-n-0 requested a review from a team as a code owner August 4, 2025 16:08
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 4, 2025
@pr-commenter

pr-commenter Bot commented Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-05 12:44:46

Comparing candidate commit f889cf2 in PR branch flavien/envoy/config-tests with baseline commit ccbdcd9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@e-n-0
e-n-0 force-pushed the flavien/envoy/config-tests branch from c659ebf to 016fa0c Compare August 4, 2025 16:11
@e-n-0

e-n-0 commented Aug 5, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 5, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-05 12:37:58 UTC ℹ️ Start processing command /merge

2025-08-05 12:38:08 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-08-05 12:47:23 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 13m (p90).

2025-08-05 12:57:58 UTC ℹ️ MergeQueue: This merge request was merged

@genesor genesor changed the title contrib/envoy: tests for config for serviceextensions chore(contrib/envoy): tests for config for serviceextensions Aug 5, 2025
@dd-mergequeue
dd-mergequeue Bot merged commit 16969a6 into main Aug 5, 2025
225 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the flavien/envoy/config-tests branch August 5, 2025 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@genesor genesor genesor approved these changes
@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@e-n-0 @genesor @eliottness