feat: do not report error stack for status code errors by hannahkm · Pull Request #3837 · DataDog/dd-trace-go

hannahkm · 2025-08-01T20:28:00Z

What does this PR do?

Creates a new tag, ErrorNoStackTrace, to report errors without capturing the stack trace for our UI.
Better aligns our error tags with Error Tracking. This includes moving error.stack to error.handling_stack, moving error.details into error.stack, and deprecating error.details.

Motivation

We were creating errors and reporting the stack for status code errors. For new error stack features (#3709), this causes us to create two error stacks: one starting from SetTag and one started from error creation. To avoid this, and also because reporting these error stacks is superfluous, we want to prevent reporting these stacks to hide them from our UI.

For information on what each tag represents, refer to this (internal) page.

IMPORTANT: this might be considered a breaking change for Error Tracking. Please check with the ET team before releasing this feature.

Reviewer's Checklist

Changed code has unit tests for its functionality at or near 100% coverage.
System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
There is a benchmark for any new code, or changes to existing code.
If this interacts with the agent in a new way, a system test has been added.
New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
Add an appropriate team label so this PR gets put in the right place for the release notes.
Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

pr-commenter · 2025-08-01T20:30:24Z

Benchmarks

Benchmark execution time: 2025-09-24 14:35:03

Comparing candidate commit 4fefb03 in PR branch hannahkm/new-error-tag with baseline commit e2c8d45 in branch main.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 2 metrics, 0 unstable metrics.

scenario:BenchmarkSetTagStringPtr-24

🟥 execution_time [+5.953ns; +9.007ns] or [+4.261%; +6.447%]

kakkoyun · 2025-09-16T07:55:54Z

 	ErrorStack = "error.stack"

+	// ErrorHandlingStack specifies the stack dump when the error is captured.
+	ErrorHandlingStack = "error.handling_stack"


We are adding these two new tags, what are the implications on the ingestion side? Especially for error tracking?

The new tags will change the behavior of error tags on spans; handling_stack should already be handled from the error tracking side, but we just haven't been taking advantage of it earlier. The fingerprints of spans will change after we release this PR, so we should give them a heads-up before so that they can adjust in the backend.

Thanks for the explanation ☺️

hannahkm · 2025-09-24T14:34:37Z

/merge

dd-devflow-routing-codex · 2025-09-24T14:34:41Z

View all feedbacks in Devflow UI.

2025-09-24 14:34:41 UTC ℹ️ Start processing command /merge

2025-09-24 14:34:51 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-09-24 18:35:08 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

datadog-official · 2025-09-24T14:52:22Z

⚠️ Tests

⚠️ Warnings

❄️ 1 New flaky test detected

TestWrapConsumerGroupHandler from github.com/DataDog/dd-trace-go/contrib/IBM/sarama/v2 (Datadog) (✨ Fix with BitsAI)

Failed

=== RUN   TestWrapConsumerGroupHandler
2025/09/24 14:48:13 Sarama consumer up and running!...
    consumer_group_test.go:146: Message claimed: value = test 1, timestamp = 2025-09-24 14:48:13.724 +0000 UTC, topic = IBM_sarama_TestWrapConsumerGroupHandler
    consumer_group_test.go:88: 
        	Error Trace:	/home/runner/work/dd-trace-go/dd-trace-go/contrib/IBM/sarama/consumer_group_test.go:88
        	Error:      	"[
        	            	name: kafka.produce
        	            	tags: map[string]interface {}{"_dd.base_service":"", "_dd.p.tid":"68d404ad00000000", "_dd.profiling.enabled":0, "_dd.top_level":1, "component":"IBM/sarama", "language":"go", "messaging.destination.name":"IBM_sarama_TestWrapConsumerGroupHandler", "messaging.kafka.partition":0, "messaging.system":"kafka", "offset":0, "resource.name":"Produce Topic IBM_sarama_TestWrapConsumerGroupHandler", "service.name":"kafka", "span.kind":"producer", "span.name":"kafka.produce", "span.type":"queue"}
...

ℹ️ Info

🧪 All tests passed

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 4fefb03 | Docs | Was this helpful? Give us feedback!}

hannahkm · 2025-09-24T18:41:33Z

/merge

dd-devflow-routing-codex · 2025-09-24T18:41:37Z

View all feedbacks in Devflow UI.

2025-09-24 18:41:37 UTC ℹ️ Start processing command /merge

2025-09-24 18:41:42 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 18m (p90).

2025-09-24 18:56:35 UTC ℹ️ MergeQueue: This merge request was merged

hannahkm added 2 commits August 1, 2025 16:25

do not record error stack for status code errors

86836bf

support new error tag type

830b0f6

github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 1, 2025

add handler stack

e7cbad2

hannahkm commented Aug 5, 2025

View reviewed changes

Comment thread ddtrace/tracer/span.go Outdated

change tag name to match convention

5e13bf3

hannahkm marked this pull request as ready for review September 12, 2025 14:57

hannahkm requested review from a team as code owners September 12, 2025 14:57

hannahkm requested a review from kakkoyun September 12, 2025 14:57

kakkoyun reviewed Sep 16, 2025

View reviewed changes

hannahkm added 2 commits September 23, 2025 10:06

completely move error.stack to error.handling_stack

65d5441

deprecate error.details

27b1c53

kakkoyun reviewed Sep 23, 2025

View reviewed changes

Comment thread ddtrace/tracer/span.go Outdated

code clean up

e80c232

kakkoyun approved these changes Sep 23, 2025

View reviewed changes

kakkoyun and others added 3 commits September 23, 2025 17:31

Merge branch 'main' into hannahkm/new-error-tag

3748d2d

Merge branch 'main' into hannahkm/new-error-tag

b529ca0

Merge branch 'main' into hannahkm/new-error-tag

4fefb03

dd-devflow Bot added the mergequeue-status: waiting label Sep 24, 2025

dd-devflow Bot added mergequeue-status: removed and removed mergequeue-status: waiting labels Sep 24, 2025

dd-devflow Bot removed the mergequeue-status: removed label Sep 24, 2025

dd-devflow Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Sep 24, 2025

dd-mergequeue Bot merged commit 64ea958 into main Sep 24, 2025
261 of 269 checks passed

dd-devflow Bot removed the mergequeue-status: in_progress label Sep 24, 2025

dd-mergequeue Bot deleted the hannahkm/new-error-tag branch September 24, 2025 18:56

dd-devflow Bot added the mergequeue-status: done label Sep 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: do not report error stack for status code errors#3837

feat: do not report error stack for status code errors#3837
dd-mergequeue[bot] merged 10 commits into
mainfrom
hannahkm/new-error-tag

hannahkm commented Aug 1, 2025 •

edited

Loading

Uh oh!

pr-commenter Bot commented Aug 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

kakkoyun Sep 16, 2025

Uh oh!

hannahkm Sep 17, 2025

Uh oh!

kakkoyun Sep 18, 2025

Uh oh!

Uh oh!

Uh oh!

hannahkm commented Sep 24, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

datadog-official Bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

hannahkm commented Sep 24, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Sep 24, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hannahkm commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Motivation

Reviewer's Checklist

Uh oh!

pr-commenter Bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

scenario:BenchmarkSetTagStringPtr-24

Uh oh!

Uh oh!

kakkoyun Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

hannahkm Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

kakkoyun Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hannahkm commented Sep 24, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

datadog-official Bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Warnings

ℹ️ Info

Uh oh!

hannahkm commented Sep 24, 2025

Uh oh!

dd-devflow-routing-codex Bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hannahkm commented Aug 1, 2025 •

edited

Loading

pr-commenter Bot commented Aug 1, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Sep 24, 2025 •

edited

Loading

datadog-official Bot commented Sep 24, 2025 •

edited

Loading

dd-devflow-routing-codex Bot commented Sep 24, 2025 •

edited

Loading