Skip to content

chore(ci): Improve CI#3833

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
kakkoyun/add-back-checklocks
Aug 1, 2025
Merged

chore(ci): Improve CI#3833
dd-mergequeue[bot] merged 1 commit into
mainfrom
kakkoyun/add-back-checklocks

Conversation

@kakkoyun

@kakkoyun kakkoyun commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Now that #3819 excluded the tool dependencies, this adds the reverted changes back from "Improve CI and dogfooding practices for dd-trace-go #3727"

ref:

And also;

  • Add embedmd to development tools for automatic documentation embedding
  • Add 'make docs' command to update README files with current help outputs
  • Add CI check to ensure documentation stays up-to-date
  • Generate clean, idempotent help outputs for consistent documentation

Signed-off-by: Kemal Akkoyun [email protected]

@kakkoyun
chore(ci): Improve CI
6bdd1c8 
Add the reverted chages back from "Improve CI and dogfooding practices
for dd-trace-go #3727"

And also;
  - Add embedmd to development tools for automatic documentation embedding
  - Add 'make docs' command to update README files with current help outputs
  - Add CI check to ensure documentation stays up-to-date
  - Generate clean, idempotent help outputs for consistent documentation

Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
kakkoyun requested a review from a team as a code owner August 1, 2025 14:04
@pr-commenter

pr-commenter Bot commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-01 14:19:49

Comparing candidate commit 6bdd1c8 in PR branch kakkoyun/add-back-checklocks with baseline commit 3ebea97 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@kakkoyun

kakkoyun commented Aug 1, 2025

Copy link
Copy Markdown
Member Author

cc @eliottness @darccio

@kakkoyun kakkoyun mentioned this pull request Aug 1, 2025
Merged
darccio
darccio approved these changes Aug 1, 2025
View reviewed changes
Comment thread .github/workflows/static-checks.yml
# our library builds with all of the Go versions we claim to support,
# without having to download a newer one.
GOTOOLCHAIN: local
GODEBUG: "x509negativeserial=1"

@darccio darccio Aug 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a reminder, this GODEBUG config is due to #3199, and probably we can upgrade our mssql tests to use the fixed versions instead of keeping this workaround cc @hannahkm

@kakkoyun

kakkoyun commented Aug 1, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-01 15:50:35 UTC ℹ️ Start processing command /merge

2025-08-01 15:50:43 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-01 16:02:15 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 80c9990 into main Aug 1, 2025
246 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the kakkoyun/add-back-checklocks branch August 1, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kakkoyun @darccio @eliottness