Skip to content

ci: remove commit sha tag from released images and add it as container label#3832

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
flavien/envoy/remove-release-commit-tag
Aug 1, 2025
Merged

ci: remove commit sha tag from released images and add it as container label#3832
dd-mergequeue[bot] merged 1 commit into
mainfrom
flavien/envoy/remove-release-commit-tag

Conversation

@e-n-0

@e-n-0 e-n-0 commented Aug 1, 2025

Copy link
Copy Markdown
Member

What does this PR do?

This PR removes the commit sha tag that is added to all docker images released (service extension callout and request mirror). The commit sha is now set as a label.

Motivation

Less orhpan tags in the registry for a better visibility of all released versions tags.

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@e-n-0
e-n-0 requested review from a team as code owners August 1, 2025 13:32
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Aug 1, 2025
@e-n-0
e-n-0 force-pushed the flavien/envoy/remove-release-commit-tag branch from 1c7d4a8 to d32ff00 Compare August 1, 2025 13:33
@pr-commenter

pr-commenter Bot commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-08-01 13:47:22

Comparing candidate commit d32ff00 in PR branch flavien/envoy/remove-release-commit-tag with baseline commit c2487ed in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@e-n-0 e-n-0 changed the title ci: remove commit sha tag from released image and add it as container label ci: remove commit sha tag from released images and add it as container label Aug 1, 2025
@e-n-0
e-n-0 requested a review from eliottness August 1, 2025 13:36
@e-n-0

e-n-0 commented Aug 1, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-01 13:56:18 UTC ℹ️ Start processing command /merge

2025-08-01 13:56:32 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-01 14:08:12 UTC ❌ MergeQueue: The checks failed on this merge request

Tests failed on this commit c9c19e2:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@e-n-0

e-n-0 commented Aug 1, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-01 14:18:46 UTC ℹ️ Start processing command /merge

2025-08-01 14:18:58 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-01 14:29:36 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 4ea8389 into main Aug 1, 2025
236 of 239 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the flavien/envoy/remove-release-commit-tag branch August 1, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eliottness eliottness eliottness approved these changes

Assignees

No one assigned

Labels

apm:ecosystem contrib/* related feature requests or bugs mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@e-n-0 @eliottness