Skip to content

Avoid using GITHUB_TOKEN for PR creation#3828

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
christoph.hamsen/avoid-github-token-for-pr-creation
Aug 1, 2025
Merged

Avoid using GITHUB_TOKEN for PR creation#3828
dd-mergequeue[bot] merged 1 commit into
mainfrom
christoph.hamsen/avoid-github-token-for-pr-creation

Conversation

@xopham

@xopham xopham commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@xopham
xopham marked this pull request as ready for review July 31, 2025 22:10
@xopham
xopham requested a review from a team as a code owner July 31, 2025 22:10
@xopham
xopham force-pushed the christoph.hamsen/avoid-github-token-for-pr-creation branch from 6a4ef52 to 6cbc721 Compare July 31, 2025 22:12
@pr-commenter

pr-commenter Bot commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-07-31 22:26:23

Comparing candidate commit 6cbc721 in PR branch christoph.hamsen/avoid-github-token-for-pr-creation with baseline commit 5d73761 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@darccio

darccio commented Aug 1, 2025

Copy link
Copy Markdown
Member

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-08-01 07:42:13 UTC ℹ️ Start processing command /merge

2025-08-01 07:42:18 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-08-01 07:53:46 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 3ebea97 into main Aug 1, 2025
223 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the christoph.hamsen/avoid-github-token-for-pr-creation branch August 1, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xopham @darccio