Skip to content

ci: add STS token retrieval step for label check#3824

Merged
dd-mergequeue[bot] merged 1 commit into
mainfrom
ben.db/fix-pat-label
Jul 31, 2025
Merged

ci: add STS token retrieval step for label check#3824
dd-mergequeue[bot] merged 1 commit into
mainfrom
ben.db/fix-pat-label

Conversation

@genesor

@genesor genesor commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

The auto adding of labels is currently broken because of PAT deprecation. This PR fixes it.

image

The label was added by the automation when the PR included a, now reverted, contrib modification

Motivation

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@pr-commenter

pr-commenter Bot commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-07-31 13:52:30

Comparing candidate commit e7906d8 in PR branch ben.db/fix-pat-label with baseline commit a4e079e in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@genesor
genesor force-pushed the ben.db/fix-pat-label branch from 87c857c to 509509e Compare July 31, 2025 11:48
kakkoyun
kakkoyun reviewed Jul 31, 2025
View reviewed changes
Comment thread .github/chainguard/self.reviewdog.sts.yaml
@@ -1,7 +1,7 @@
issuer: https://token.actions.githubusercontent.com

@kakkoyun kakkoyun Jul 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intention was to remove this file and use the https://github.com/DataDog/dd-trace-go/blob/main/.github/chainguard/self.pr-static-checks.sts.yaml

I forgot to send the follow-up PR. This file is not used right now.

That being said, I'm not sure what the convention should be for creating these files.
I'm open to suggestions.

cc @darccio

@genesor genesor Jul 31, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I switched the ref to self.pr-static-checks.sts.yaml to see if it works.

To do so we need to check the job_workflow_ref too. I don't know exactly how it works but i'm trying stuff.

@kakkoyun kakkoyun Jul 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They won't work if the changes are not merged on the "main" unfortunately.

@darccio darccio Jul 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convention says to create a policy file for each usage.

@genesor
genesor force-pushed the ben.db/fix-pat-label branch 2 times, most recently from f460ffd to b54fa9e Compare July 31, 2025 13:10
@github-actions github-actions Bot added the apm:ecosystem contrib/* related feature requests or bugs label Jul 31, 2025
@genesor
genesor force-pushed the ben.db/fix-pat-label branch from e5d4fe3 to e7906d8 Compare July 31, 2025 13:40
@genesor
genesor marked this pull request as ready for review July 31, 2025 13:40
@genesor
genesor requested a review from a team as a code owner July 31, 2025 13:40
@genesor genesor removed the apm:ecosystem contrib/* related feature requests or bugs label Jul 31, 2025
@genesor

genesor commented Jul 31, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-31 13:50:47 UTC ℹ️ Start processing command /merge

2025-07-31 13:51:12 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-07-31 13:57:35 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-07-31 14:08:40 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 157de56 into main Jul 31, 2025
222 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the ben.db/fix-pat-label branch July 31, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kakkoyun kakkoyun kakkoyun left review comments
@darccio darccio darccio approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@genesor @darccio @kakkoyun