Skip to content

chore(tools): Improve develoment tool management#3819

Merged
dd-mergequeue[bot] merged 3 commits into
mainfrom
kakkoyun/remove_tool_deps
Jul 31, 2025
Merged

chore(tools): Improve develoment tool management#3819
dd-mergequeue[bot] merged 3 commits into
mainfrom
kakkoyun/remove_tool_deps

Conversation

@kakkoyun

@kakkoyun kakkoyun commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown
Member
  • Remove tool dependencies from go.work
  • Unify naming conventions
  • Improve development tool management

Motivation

We should make sure any of the development tool dependencies or Go minimum required toolchain version for a development tool to effect the public facing modules.

Also, revert the revert of #3807

Reviewer's Checklist

  • Changed code has unit tests for its functionality at or near 100% coverage.
  • System-Tests covering this feature have been added and enabled with the va.b.c-dev version tag.
  • There is a benchmark for any new code, or changes to existing code.
  • If this interacts with the agent in a new way, a system test has been added.
  • New code is free of linting errors. You can check this by running ./scripts/lint.sh locally.
  • Add an appropriate team label so this PR gets put in the right place for the release notes.
  • Non-trivial go.mod changes, e.g. adding new modules, are reviewed by @DataDog/dd-trace-go-guild.

Unsure? Have a question? Request a review!

@kakkoyun
kakkoyun requested a review from a team as a code owner July 30, 2025 11:47
@pr-commenter

pr-commenter Bot commented Jul 30, 2025 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2025-07-31 12:35:10

Comparing candidate commit 4c3734b in PR branch kakkoyun/remove_tool_deps with baseline commit 15458fd in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

@kakkoyun
kakkoyun force-pushed the kakkoyun/remove_tool_deps branch from 913e578 to efedec8 Compare July 30, 2025 11:54
@kakkoyun
kakkoyun requested review from a team as code owners July 30, 2025 11:54
@kakkoyun
kakkoyun force-pushed the kakkoyun/remove_tool_deps branch 2 times, most recently from 7eab84e to 8804d01 Compare July 30, 2025 12:10
@kakkoyun
kakkoyun marked this pull request as draft July 30, 2025 12:31
darccio
darccio reviewed Jul 30, 2025
View reviewed changes
Comment thread .github/actions/setup-go/action.yml
Comment thread _tools/README.md
@kakkoyun
kakkoyun force-pushed the kakkoyun/remove_tool_deps branch 6 times, most recently from 39eaf7a to c6c7deb Compare July 31, 2025 11:48
@kakkoyun
Improve development tool management
4c3734b 
- Make sure _tools/go.mod is up-to-date
- Add a Makefile
- Update/Add documentation
- Update existing scripts

Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
kakkoyun force-pushed the kakkoyun/remove_tool_deps branch from c6c7deb to 4c3734b Compare July 31, 2025 12:22
@kakkoyun
kakkoyun requested review from darccio and hannahkm July 31, 2025 12:25
@kakkoyun
kakkoyun marked this pull request as ready for review July 31, 2025 12:25
darccio
darccio reviewed Jul 31, 2025
View reviewed changes
Comment thread scripts/test.sh
Comment on lines -41 to -48
-l|--lint)
lint=true
shift
;;
-t|--tools)
tools=true
shift
;;

@darccio darccio Jul 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kakkoyun QQ: what's replacing the lint command?

@kakkoyun kakkoyun Jul 31, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make lint and there is another scripts/lint.sh is coming in my reverted PR.

@kakkoyun kakkoyun Jul 31, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3807

@darccio darccio Jul 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it was avoiding my vision multiple times...

darccio
darccio approved these changes Jul 31, 2025
View reviewed changes
Comment thread scripts/test.sh
Comment on lines -41 to -48
-l|--lint)
lint=true
shift
;;
-t|--tools)
tools=true
shift
;;

@darccio darccio Jul 31, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, it was avoiding my vision multiple times...

hannahkm
hannahkm approved these changes Jul 31, 2025
View reviewed changes
Comment thread _tools/go.mod
google.golang.org/protobuf v1.33.0
google.golang.org/grpc/cmd/protoc-gen-go-grpc v1.5.1
google.golang.org/protobuf v1.36.6
gotest.tools/gotestsum v1.12.3

@hannahkm hannahkm Jul 31, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be the only place left that controls the versioning for things like gotestsum, right? 👍🏼

@kakkoyun kakkoyun Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This should be true for all the tools.
I have some other work that I need to be synced when I revive #3727

@kakkoyun

kakkoyun commented Jul 31, 2025

Copy link
Copy Markdown
Member Author

/merge

@dd-devflow-routing-codex

dd-devflow-routing-codex Bot commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2025-07-31 14:05:34 UTC ℹ️ Start processing command /merge

2025-07-31 14:05:47 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-07-31 15:02:29 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 14m (p90).

2025-07-31 15:13:15 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue
dd-mergequeue Bot merged commit 26d4449 into main Jul 31, 2025
244 checks passed
@dd-mergequeue
dd-mergequeue Bot deleted the kakkoyun/remove_tool_deps branch July 31, 2025 15:13
@kakkoyun kakkoyun mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@darccio darccio darccio approved these changes
@hannahkm hannahkm hannahkm approved these changes
@nsrip-dd nsrip-dd nsrip-dd approved these changes

Assignees

No one assigned

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kakkoyun @darccio @hannahkm @nsrip-dd